blu3mania / npp-papyrus

Notepad++ plugin to provide Papyrus scripting language support to Notepad++, such as syntax highlighting with automatic recognition of class names/functions/properties, keywords matching, and hyperlinks to referenced scripts. It also comes with a compiler that can provide compilation errors in a separate list window, as well as inline annotation and indication where errors are reported, plus support anonymization of compiled .pex files.
GNU General Public License v3.0
24 stars 7 forks source link

Thick composition underline in the Keyword Matcher has a duller tone than selected #49

Closed SonicRay100 closed 1 year ago

SonicRay100 commented 1 year ago

Under keyword matcher, selecting "Thick composition underline" turns the colour selected dull in the latest version of the plugin (v1.0.0 (Build 31) ) using the latest version of Notepad++ (v8.5.4 64-bit).

What I have tested:

What happens in an older version of the plugin:

Papyrus Plugin = v0.3.0 (Build 24) Notepad++ v8.3.3 64-bit

What happens in the newer version of the plugin

Papyrus Plugin = v1.0.0 (Build 31) Notepad++ v8.5.4 64-bit

Image:

Untitled

blu3mania commented 1 year ago

This is caused by Scintilla's change in 5.3.0 (see https://www.scintilla.org/ScintillaHistory.html) that applied outline alpha to INDIC_COMPOSITIONTHICK. I just pushed a commit to force the outline to always be opaque.

blu3mania commented 1 year ago

Released v1.0.1 so I am closing this.

SonicRay100 commented 1 year ago

Awesome. Thanks for the great work :).