blubber / django_injector

Dependency injection in Django.
BSD 2-Clause "Simplified" License
49 stars 7 forks source link

Add tests, request scope, HttpRequest bindings and remove custom inject decorator #1

Closed jstasiak closed 5 years ago

jstasiak commented 5 years ago

Hey,

First of all – thank you for the useful project. I went ahead and make some changes to make it more suitable for my needs, I decided to send you all of them in a single pull request but I'm happy to split them into four pull requests (it's one commit per pull request).

The changes are as follows:

asyncee commented 5 years ago

Hello, @jstasiak! I have reviewed your changes and want to say that it is very nice work. Thanks! I had to fork your branch to use in my pet project until this PR gets merged by @blubber (i hope).

Also i want to thank @blubber for such a nice integration library.

blubber commented 5 years ago

I have been out of the country on vacation. I’ll take a look at this as soon as I get back next week. Thanks)

blubber commented 5 years ago

Great contributions, thanks! I'm going to merge it right now and setup the integration with Travis later.

jstasiak commented 5 years ago

Cheers!