search

bluceldg / libyuv

Automatically exported from code.google.com/p/libyuv
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Chrome roll of libyuv #426

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
update libyuv used by chrome.

webrtc and gtp use the chrome version of libyuv now, so to update those 
projects, chrome requires a roll.

It should be something like

cd d:\src\chrome\src

gclient sync
git checkout master
git pull

cd third_party\libyuv
git fetch origin
cd ..\..

roll-dep third_party/libyuv 1367

optional
git checkout -b my-libyuv-roll
git add DEPS
git commit 
git pull --rebase origin master

Original issue reported on code.google.com by fbarch...@chromium.org on 14 Apr 2015 at 12:56

GoogleCodeExporter commented 9 years ago 
r1367 has a build error on OSX

[793/2169] CXX obj/cc/resources/cc.layer_updater.o
FAILED: cd ../../third_party/libyuv; export 
BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/mac/build/src/out/Release; 
export CONFIGURATION=Release; export PRODUCT_NAME=libyuv_nacl; export 
SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Dev
eloper/SDKs/MacOSX10.6.sdk; export 
SRCROOT=/Volumes/data/b/build/slave/mac/build/src/out/Release/../../third_party/
libyuv; export SOURCE_ROOT="${SRCROOT}"; export 
TARGET_BUILD_DIR=/Volumes/data/b/build/slave/mac/build/src/out/Release; export 
TEMP_DIR="${TMPDIR}";python ../../native_client/build/build_nexe.py --root 
../.. --product-dir ../../out/Release/xyz --config-name Release -t 
../../native_client/toolchain/ --arch pnacl --build newlib_plib --name 
../../out/Release/gen/tc_pnacl_newlib/lib/libyuv_nacl.a --objdir 
../../out/Release/obj/third_party/libyuv/libyuv_nacl.gen/pnacl_newlib-pnacl/liby
uv_nacl "--include-dirs=../../out/Release/gen/tc_pnacl_newlib/include ../.. 
\"../../out/Release/gen\" include" "--compile_flags=-O2 -g -Wall 
-fdiagnostics-show-option -Werror  -gline-tables-only -Wno-unused-function 
-Wno-char-subscripts -Wno-c++11-extensions -Wno-unnamed-type-template-args 
-Wno-extra-semi -Wno-unused-private-field -Wno-char-subscripts 
-Wno-unused-function \"-std=gnu++11\" " --gomadir /Volumes/data/b/build/goma 
"--defines=\"__STDC_LIMIT_MACROS=1\" \"__STDC_FORMAT_MACROS=1\" 
\"_GNU_SOURCE=1\" \"_DEFAULT_SOURCE=1\" \"_BSD_SOURCE=1\" 
\"_POSIX_C_SOURCE=199506\" \"_XOPEN_SOURCE=600\" 
\"DYNAMIC_ANNOTATIONS_ENABLED=1\" \"DYNAMIC_ANNOTATIONS_PREFIX=NACL_\" 
\"NACL_BUILD_ARCH=x86\" V8_DEPRECATION_WARNINGS 
\"__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0\" CHROMIUM_BUILD 
\"CR_CLANG_REVISION=233105-1\" \"TOOLKIT_VIEWS=1\" \"USE_LIBJPEG_TURBO=1\" 
ENABLE_ONE_CLICK_SIGNIN ENABLE_PRE_SYNC_BACKUP \"ENABLE_REMOTING=1\" 
\"ENABLE_WEBRTC=1\" \"ENABLE_MEDIA_ROUTER=1\" ENABLE_PEPPER_CDMS 
ENABLE_CONFIGURATION_POLICY ENABLE_NOTIFICATIONS \"ENABLE_HIDPI=1\" 
SYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE DONT_EMBED_BUILD_METADATA 
\"DCHECK_ALWAYS_ON=1\" \"ENABLE_TASK_MANAGER=1\" \"ENABLE_EXTENSIONS=1\" 
\"ENABLE_PLUGIN_INSTALLATION=1\" \"ENABLE_PLUGINS=1\" 
\"ENABLE_SESSION_SERVICE=1\" \"ENABLE_THEMES=1\" \"ENABLE_AUTOFILL_DIALOG=1\" 
\"ENABLE_BACKGROUND=1\" \"ENABLE_GOOGLE_NOW=1\" \"CLD_VERSION=2\" 
\"ENABLE_PRINTING=1\" \"ENABLE_BASIC_PRINTING=1\" \"ENABLE_PRINT_PREVIEW=1\" 
\"ENABLE_SPELLCHECK=1\" \"ENABLE_CAPTIVE_PORTAL_DETECTION=1\" 
\"ENABLE_APP_LIST=1\" \"ENABLE_SETTINGS_APP=1\" \"ENABLE_SUPERVISED_USERS=1\" 
\"ENABLE_SERVICE_DISCOVERY=1\" \"ENABLE_WIFI_BOOTSTRAPPING=1\" 
V8_USE_EXTERNAL_STARTUP_DATA \"USE_LIBPCI=1\" \"USE_OPENSSL=1\"" 
"--link_flags=-B../../out/Release/gen/tc_pnacl_newlib/lib  " 
"--source-list=../../out/gypfiles/third_party/libyuv/pnacl_newlib.libyuv_nacl.so
urce_list.gypcmd"
source/convert_from.cc:1028:10: error: unused variable 'I422ToRGB565Row' 
[-Werror,-Wunused-variable]
  void (*I422ToRGB565Row)(const uint8* y_buf,
         ^
1 error generated.
FAILED with 1: /Volumes/data/b/build/goma/gomacc 
../../native_client/toolchain/mac_x86/pnacl_newlib/bin/pnacl-clang++ -c 
source/convert_from.cc -o 
../../out/Release/obj/third_party/libyuv/libyuv_nacl.gen/pnacl_newlib-pnacl/liby
uv_nacl/convert_from_0c4bd9ed.o -MD -MF 
../../out/Release/obj/third_party/libyuv/libyuv_nacl.gen/pnacl_newlib-pnacl/liby
uv_nacl/convert_from_0c4bd9ed.o.d -O2 -g -Wall -fdiagnostics-show-option 
-Werror -gline-tables-only -Wno-unused-function -Wno-char-subscripts 
-Wno-c++11-extensions -Wno-unnamed-type-template-args -Wno-extra-semi 
-Wno-unused-private-field -Wno-char-subscripts -Wno-unused-function 
-std=gnu++11 -D__STDC_LIMIT_MACROS=1 -D__STDC_FORMAT_MACROS=1 -D_GNU_SOURCE=1 
-D_DEFAULT_SOURCE=1 -D_BSD_SOURCE=1 -D_POSIX_C_SOURCE=199506 
-D_XOPEN_SOURCE=600 -DDYNAMIC_ANNOTATIONS_ENABLED=1 
-DDYNAMIC_ANNOTATIONS_PREFIX=NACL_ -DV8_DEPRECATION_WARNINGS 
-D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD 
-DCR_CLANG_REVISION=233105-1 -DTOOLKIT_VIEWS=1 -DUSE_LIBJPEG_TURBO=1 
-DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_REMOTING=1 
-DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS 
-DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 
-DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DDONT_EMBED_BUILD_METADATA 
-DDCHECK_ALWAYS_ON=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 
-DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 
-DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 
-DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_PRINTING=1 
-DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 
-DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 
-DENABLE_WIFI_BOOTSTRAPPING=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DUSE_LIBPCI=1 
-DUSE_OPENSSL=1 -DNACL_WINDOWS=0 -DNACL_OSX=0 -DNACL_LINUX=0 -DNACL_ANDROID=0 
-DNACL_BUILD_ARCH=pnacl -I../../out/Release/gen/tc_pnacl_newlib/include -I../.. 
-I../../out/Release/gen -Iinclude -DNDEBUG -std=gnu++0x -Wno-deprecated-register
Compile options: ['-O2', '-g', '-Wall', '-fdiagnostics-show-option', '-Werror', 
'-gline-tables-only', '-Wno-unused-function', '-Wno-char-subscripts', 
'-Wno-c++11-extensions', '-Wno-unnamed-type-template-args', '-Wno-extra-semi', 
'-Wno-unused-private-field', '-Wno-char-subscripts', '-Wno-unused-function', 
'-std=gnu++11', '-D__STDC_LIMIT_MACROS=1', '-D__STDC_FORMAT_MACROS=1', 
'-D_GNU_SOURCE=1', '-D_DEFAULT_SOURCE=1', '-D_BSD_SOURCE=1', 
'-D_POSIX_C_SOURCE=199506', '-D_XOPEN_SOURCE=600', 
'-DDYNAMIC_ANNOTATIONS_ENABLED=1', '-DDYNAMIC_ANNOTATIONS_PREFIX=NACL_', 
'-DV8_DEPRECATION_WARNINGS', 
'-D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0', '-DCHROMIUM_BUILD', 
'-DCR_CLANG_REVISION=233105-1', '-DTOOLKIT_VIEWS=1', '-DUSE_LIBJPEG_TURBO=1', 
'-DENABLE_ONE_CLICK_SIGNIN', '-DENABLE_PRE_SYNC_BACKUP', '-DENABLE_REMOTING=1', 
'-DENABLE_WEBRTC=1', '-DENABLE_MEDIA_ROUTER=1', '-DENABLE_PEPPER_CDMS', 
'-DENABLE_CONFIGURATION_POLICY', '-DENABLE_NOTIFICATIONS', '-DENABLE_HIDPI=1', 
'-DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE', '-DDONT_EMBED_BUILD_METADATA', 
'-DDCHECK_ALWAYS_ON=1', '-DENABLE_TASK_MANAGER=1', '-DENABLE_EXTENSIONS=1', 
'-DENABLE_PLUGIN_INSTALLATION=1', '-DENABLE_PLUGINS=1', 
'-DENABLE_SESSION_SERVICE=1', '-DENABLE_THEMES=1', 
'-DENABLE_AUTOFILL_DIALOG=1', '-DENABLE_BACKGROUND=1', '-DENABLE_GOOGLE_NOW=1', 
'-DCLD_VERSION=2', '-DENABLE_PRINTING=1', '-DENABLE_BASIC_PRINTING=1', 
'-DENABLE_PRINT_PREVIEW=1', '-DENABLE_SPELLCHECK=1', 
'-DENABLE_CAPTIVE_PORTAL_DETECTION=1', '-DENABLE_APP_LIST=1', 
'-DENABLE_SETTINGS_APP=1', '-DENABLE_SUPERVISED_USERS=1', 
'-DENABLE_SERVICE_DISCOVERY=1', '-DENABLE_WIFI_BOOTSTRAPPING=1', 
'-DV8_USE_EXTERNAL_STARTUP_DATA', '-DUSE_LIBPCI=1', '-DUSE_OPENSSL=1', 
'-DNACL_WINDOWS=0', '-DNACL_OSX=0', '-DNACL_LINUX=0', '-DNACL_ANDROID=0', 
'-DNACL_BUILD_ARCH=pnacl', '-I../../out/Release/gen/tc_pnacl_newlib/include', 
'-I../..', '-I../../out/Release/gen', '-Iinclude', '-DNDEBUG']
Linker options: ['-B../../out/Release/gen/tc_pnacl_newlib/lib']
Traceback (most recent call last):
  File "../../native_client/build/build_nexe.py", line 748, in CompileProcess
    output_queue.put((filename, build.Compile(filename)))
  File "../../native_client/build/build_nexe.py", line 563, in Compile
    raise Error('FAILED with %d: %s' % (err, ' '.join(cmd_line)))
Error: FAILED with 1: /Volumes/data/b/build/goma/gomacc 
../../native_client/toolchain/mac_x86/pnacl_newlib/bin/pnacl-clang++ -c 
source/convert_from.cc -o 
../../out/Release/obj/third_party/libyuv/libyuv_nacl.gen/pnacl_newlib-pnacl/liby
uv_nacl/convert_from_0c4bd9ed.o -MD -MF 
../../out/Release/obj/third_party/libyuv/libyuv_nacl.gen/pnacl_newlib-pnacl/liby
uv_nacl/convert_from_0c4bd9ed.o.d -O2 -g -Wall -fdiagnostics-show-option 
-Werror -gline-tables-only -Wno-unused-function -Wno-char-subscripts 
-Wno-c++11-extensions -Wno-unnamed-type-template-args -Wno-extra-semi 
-Wno-unused-private-field -Wno-char-subscripts -Wno-unused-function 
-std=gnu++11 -D__STDC_LIMIT_MACROS=1 -D__STDC_FORMAT_MACROS=1 -D_GNU_SOURCE=1 
-D_DEFAULT_SOURCE=1 -D_BSD_SOURCE=1 -D_POSIX_C_SOURCE=199506 
-D_XOPEN_SOURCE=600 -DDYNAMIC_ANNOTATIONS_ENABLED=1 
-DDYNAMIC_ANNOTATIONS_PREFIX=NACL_ -DV8_DEPRECATION_WARNINGS 
-D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD 
-DCR_CLANG_REVISION=233105-1 -DTOOLKIT_VIEWS=1 -DUSE_LIBJPEG_TURBO=1 
-DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_REMOTING=1 
-DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS 
-DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 
-DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DDONT_EMBED_BUILD_METADATA 
-DDCHECK_ALWAYS_ON=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 
-DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 
-DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 
-DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_PRINTING=1 
-DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 
-DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 
-DENABLE_WIFI_BOOTSTRAPPING=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DUSE_LIBPCI=1 
-DUSE_OPENSSL=1 -DNACL_WINDOWS=0 -DNACL_OSX=0 -DNACL_LINUX=0 -DNACL_ANDROID=0 
-DNACL_BUILD_ARCH=pnacl -I../../out/Release/gen/tc_pnacl_newlib/include -I../.. 
-I../../out/Release/gen -Iinclude -DNDEBUG -std=gnu++0x -Wno-deprecated-register

ninja: build stopped: subcommand failed.

Original comment by fbarch...@chromium.org on 14 Apr 2015 at 1:18

GoogleCodeExporter commented 9 years ago 
This roll attempt
https://webrtc-codereview.appspot.com/44179004/
break in jingle for bayer unittests.  bayer has been removed.

[134/153] LINK vie_auto_test, POSTBUILDS
FAILED: /b/build/goma/gomacc 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF 
obj/talk/media/webrtc/libjingle_media_unittest.webrtcvideoframe_unittest.o.d 
-DV8_DEPRECATION_WARNINGS -DEXPAT_RELATIVE_PATH -DFEATURE_ENABLE_VOICEMAIL 
-DGTEST_RELATIVE_PATH -DJSONCPP_RELATIVE_PATH -DLOGGING=1 -DSRTP_RELATIVE_PATH 
-DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_PSTN -DHAVE_SCTP -DHAVE_SRTP 
-DHAVE_WEBRTC_VIDEO -DHAVE_WEBRTC_VOICE 
-D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD 
-DCR_CLANG_REVISION=233105-1 -DTOOLKIT_VIEWS=1 -DUSE_LIBJPEG_TURBO=1 
-DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_REMOTING=1 
-DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS 
-DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 
-DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DDONT_EMBED_BUILD_METADATA 
-DDCHECK_ALWAYS_ON=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 
-DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 
-DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 
-DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_PRINTING=1 
-DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 
-DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 
-DENABLE_WIFI_BOOTSTRAPPING=1 -DV8_USE_EXTERNAL_STARTUP_DATA 
-DLIBPEERCONNECTION_LIB=1 -DOSX -DWEBRTC_MAC -DHASH_NAMESPACE=__gnu_cxx -DPOSIX 
-DWEBRTC_POSIX -DDISABLE_DYNAMIC_CAST -D_REENTRANT -DGTEST_HAS_POSIX_RE=0 
-DGTEST_LANG_CXX11=0 -DUNIT_TEST -DGTEST_HAS_RTTI=0 -DUSE_LIBPCI=1 
-DUSE_OPENSSL=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen 
-I../.. -I../.. -I../../third_party -I../../third_party/webrtc -I../../webrtc 
-I../../chromium/src/testing/gtest/include -I../../third_party/libyuv/include 
-I../../testing/gtest/include -I../../testing/gtest -isysroot 
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/S
DKs/MacOSX10.9.sdk -O2 -fvisibility=hidden -Werror -Wnewline-eof 
-mmacosx-version-min=10.6 -arch i386 -Wendif-labels -Wno-unused-parameter 
-Wno-missing-field-initializers -Wno-selector-type-mismatch -Wheader-hygiene 
-Wno-char-subscripts -Wno-unneeded-internal-declaration 
-Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing 
-Wno-deprecated-register -Wno-inconsistent-missing-override -std=c++11 
-fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics 
-fcolor-diagnostics -fno-strict-aliasing  -c 
../../talk/media/webrtc/webrtcvideoframe_unittest.cc -o 
obj/talk/media/webrtc/libjingle_media_unittest.webrtcvideoframe_unittest.o
In file included from ../../talk/media/webrtc/webrtcvideoframe_unittest.cc:30:
../../talk/media/base/videoframe_unittest.h:36:10: fatal error: 
'libyuv/format_conversion.h' file not found
#include "libyuv/format_conversion.h"
         ^
1 error generated.
ninja: build stopped: subcommand failed.

/b/build/goma/goma_ctl.sh stat
request: total=90 success=89 failure=1
 compiler_proxy: fail=0

Original comment by fbarch...@chromium.org on 14 Apr 2015 at 6:07

GoogleCodeExporter commented 9 years ago 
blink rebased
https://code.google.com/p/chromium/issues/detail?id=476933

Original comment by fbarch...@chromium.org on 14 Apr 2015 at 6:58

GoogleCodeExporter commented 9 years ago

Original comment by fbarch...@chromium.org on 16 Apr 2015 at 10:23

GoogleCodeExporter commented 9 years ago 
Does this fix the 32-byte alignment directives in row_win.cc?

Original comment by brucedaw...@chromium.org on 16 Apr 2015 at 10:28

GoogleCodeExporter commented 9 years ago 
no, another roll is needed.
re-opening, since this bug has some information on whats needed to roll.

The roll command should be
roll-dep third_party/libyuv 1374

d:\src\chrome\src>roll-dep third_party/libyuv 1374
Traceback (most recent call last):
  File "c:\bin\depot_tools\\roll_dep.py", line 402, in <module>
    sys.exit(main(sys.argv[1:]))
  File "c:\bin\depot_tools\\roll_dep.py", line 395, in main
    (git_rev, svn_rev) = get_git_revision(dep_path, revision)
  File "c:\bin\depot_tools\\roll_dep.py", line 177, in get_git_revision
    git_revision = convert_svn_revision(dep_path, revision)
  File "c:\bin\depot_tools\\roll_dep.py", line 152, in convert_svn_revision
    log_p.terminate()
UnboundLocalError: local variable 'log_p' referenced before assignment

Original comment by fbarch...@google.com on 20 Apr 2015 at 11:24

GoogleCodeExporter commented 9 years ago 
The error on Windows is already reported in 
https://code.google.com/p/chromium/issues/detail?id=436818, i.e. Windows is not 
supported for that script.

Original comment by kjellan...@google.com on 21 Apr 2015 at 5:15

GoogleCodeExporter commented 9 years ago 
Used Mac to roll-dep third_party/libyuv 1374
https://codereview.chromium.org/1094223002/

additional rolls needed for nacl and ios changes (r1378)

Original comment by fbarch...@google.com on 22 Apr 2015 at 8:28

GoogleCodeExporter commented 9 years ago 
r1374 is in chrome head now, but has an ios build error.
r1382 needed to fix that.  or start with r1378 for nacl.

Original comment by fbarch...@google.com on 28 Apr 2015 at 1:10

GoogleCodeExporter commented 9 years ago 
ios 64 bit build issues resolved.  a roll is needed to r1404

Original comment by fbarch...@google.com on 7 May 2015 at 6:44

GoogleCodeExporter commented 9 years ago 
Sounds great. Can you roll it in or are you asking for help doing so?

Original comment by kjellan...@google.com on 8 May 2015 at 8:01

GoogleCodeExporter commented 9 years ago

Original comment by fbarch...@google.com on 24 Jun 2015 at 2:20