blue-build / cli

BlueBuild's command line program that builds custom Fedora Atomic images based on your recipe.yml
https://blue-build.org/
Apache License 2.0
72 stars 9 forks source link

fix: Supply `ARG`'s for updating `image-info.json` #130

Closed gmpinder closed 7 months ago

gmpinder commented 7 months ago

Currently the way that our signing module works is that it will update the /usr/share/ublue-os/image-info.json file with just a couple of fields changed. It was pointed out that ublue images have more information that we are updating.

Bazzite file template:

{
  "image-name": "$IMAGE_NAME",
  "image-flavor": "$IMAGE_FLAVOR",
  "image-vendor": "$IMAGE_VENDOR",
  "image-ref": "$IMAGE_REF",
  "image-tag": "$IMAGE_TAG",
  "image-branch": "$IMAGE_BRANCH",
  "base-image-name": "$BASE_IMAGE_NAME",
  "fedora-version": "$FEDORA_MAJOR_VERSION"
}

Bluebuild file template:

{
    "image-ref": "IMAGE_REF",
    "image-tag": "latest",
    "image-vendor": "bluebuild",
    "fedora-version": "FEDORA_MAJOR_VERSION"
}

Proposed Solution

We should have the CLI tool gather all of the necessary details to fill out this file and supply them via ARG's in the Containerfile. Then we update the signing module to make use of the new information. Corresponding issue is located here.

We would most likely want to create our own path that would be /usr/share/{{ vendor }}/image-info.json.

gmpinder commented 7 months ago

We will want to make this solution generic for any registry and source control server that wants to sign their image (i.e. GitLab and GitTea).

gmpinder commented 7 months ago

Turns out the image-info.json was a ublue specific thing. Closing this issue