blue-build / cli

BlueBuild's command line program that builds custom Fedora Atomic images based on your recipe.yml
https://blue-build.org/
Apache License 2.0
66 stars 6 forks source link

instead of suffixing fedora version in tags, suffix the alt-tag or `latest` #204

Closed noahdotpy closed 1 week ago

noahdotpy commented 1 month ago

Currently my tags look something like this for the alt-tags set as only stable:

# bluefin-dx:stable
Tags: [
    "40",
    "20240715-40",
    "stable",
    "0cb40ac-40",
]

The generated tags for latest channel of this same image is this:

# bluefin-dx:latest
Tags: [
    "40",
    "20240715-40",
    "latest",
    "0cb40ac-40",
]

As you can see there is very major overlap

Latest and stable are on the same fedora version but are actually quite significantly different (see announcement of stable tag for bluefin)

I think it would be better if the tags were like this instead, with everything suffixed with -stable (aka the alt-tag chosen:

# removed the 40 tag
Tags: [
    "20240715-stable",
    "stable",
    "0cb40ac-stable",
]
xynydev commented 1 month ago

I was initially shocked because I thought we'd specced out every overlap. But now I'm just thinking: if latest and stable is the same version, why do you care about having separate tags?

I guess in my view the textual/numbered version tags are equivalent, with the textual ones being aliases to the numbered ones, but you are using them to mean something else?

noahdotpy commented 1 month ago

So in bluefin/aurora the stable tag is pretty much latest but with a gated kernel (from CoreOS stable), and it builds weekly.

The stable tag is the same fedora version as latest, but is actually different with some stuff.

I will probably end up just disabling the latest tag building anyway.

Maybe we should, instead of -40 have -stable?

noahdotpy commented 1 month ago

more info can be found on the bluefin 3.0 release announcement on discourse

gmpinder commented 1 month ago

Yeah I didn't really take into account using the same version number on the same image. Yeah I'm thinking that the proposed set of tags is the best way to handle this kind of thing. Then we can go back to having the timestamp tag but with -alt-tag tacked onto it.

gmpinder commented 1 month ago

We would still want to fully replace latest in the list of tags

gmpinder commented 1 month ago

This will need to wait until https://github.com/blue-build/cli/pull/197 is merged in.

gmpinder commented 1 month ago

@qoijjj as a heads up for future tag changes.

noahdotpy commented 1 month ago

How would it handle multiple alt-tags, would it do a tag with every alt-tag listed?

xynydev commented 1 month ago

I think it would just create xxx-alt-tag-one and xxx-alt-tag-two separately. If you want a tag with multiple alt-tags listed, you don't want multiple alt-tags.