Nvidia akmods logic needs to be updated

blue-build / cli

BlueBuild's command line program that builds custom Fedora Atomic images based on your recipe.yml

https://blue-build.org/

Apache License 2.0

71 stars 9 forks source link

Nvidia akmods logic needs to be updated #240

Open fiftydinar opened 1 week ago

fiftydinar commented 1 week ago

Ublue dropped versioning, so it always builds the newest one. Which means that nvidia-version entry is no longer needed.

Maybe nvidia: false by default can substitute legacy nvidia-version entry.

They also build the image in proprietary & open kernel module, so they are versioned like this: ghcr.io/ublue-os/akmods-nvidia:main-${OS_VERSION} ghcr.io/ublue-os/akmods-nvidia-open:main-${OS_VERSION}

Maybe nvidia: open/proprietary entry option looks good.

What do you think?

gmpinder commented 1 week ago

I don't know if switching from a boolean to an enum would be a smart move. If I can find a way to accept both a bool and enum, that could work. We would have nvidia: true be equivalent to nvidia: proprietary since that logic would bear the same image. For nvidia-version, we can just ignore it/let the json schema handle validation.