refactor!: make modules the main focus, move files into module folders

blue-build / modules

BlueBuild standard modules used for building your Atomic Images

Apache License 2.0

24 stars 1 forks source link

refactor!: make modules the main focus, move files into module folders #103

Closed xynydev closed 8 months ago

xynydev commented 8 months ago

Less clutter overall
A lot of the bling was unmaintained and underutilized
This part of the transition being discussed here: https://github.com/ublue-os/main/issues/476

This is a breaking change that removes features, features that were unmaintained and undocumented (or badly documented).

fiftydinar commented 8 months ago

Looks very good.

Maybe we can remove ublue-os backgrounds rpm related stuff here too?

xynydev commented 8 months ago

Maybe we can remove ublue-os backgrounds rpm related stuff here too?

I was thinking that'd be a later PR but I can do it now too, sure.

fiftydinar commented 8 months ago

https://github.com/ublue-os/bling/blob/refactor/modules/bling/bling.sh#L12

This one needs to be: export BLING_DIRECTORY="/tmp/modules/bling"

xynydev commented 8 months ago

This one needs to be: export BLING_DIRECTORY="/tmp/modules/bling"

Good catch! This doesn't need to be at all actually, the $MODULE_DIRECTORYvar (supplied by build.sh, but also manually set just in case) is used instead.

fiftydinar commented 8 months ago

I would approve