search

blue-build / modules

BlueBuild standard modules used for building your Atomic Images
Apache License 2.0
23 stars 25 forks source link

feat: add signing module to replace `signing.sh` #111

Closed gerblesh closed 5 months ago

gerblesh commented 5 months ago

This PR adds a signing module to replace the script signing.sh in startingpoint and template. I haven't tested it yet, so testing is welcome. I will probably get this tested tommorrow if I have time.

xynydev commented 5 months ago

Thanks! My current image with signing.sh has this peculiar error. Are namespace clashes account for here somehow?

Error: initializing source docker://ghcr.io/blue-build/cli:latest-installer: Error parsing signature storage configuration: "docker" namespace "ghcr.io/ublue-os" defined both in "/etc/containers/registries.d/linuxyz.yaml" and "/etc/containers/registries.d/ublue-os.yaml"

I found the cause of that error, it's this line in this module sed -i "s ghcr.io/IMAGENAME $IMAGE_REGISTRY g" "$CONTAINER_DIR/registries.d/$IMAGE_NAME.yaml" (same same but different in signing.sh). It's basically writing a file into /etc/containers/registries.d/ that uses the $IMAGE_REGISTRY var to set the contents. This is by default ghcr.io/ublue-os but changed in startingpoint's build.yml and not in cli. So not your fault, then I'll file for this cli.

gerblesh commented 5 months ago

shellcheck is passing now