search

blue-build / modules

BlueBuild standard modules used for building your Atomic Images
Apache License 2.0
23 stars 25 forks source link

chore(rpm-ostree): Remove optfix workaround, when upstream optfix is merged #112

Open xynydev opened 5 months ago

xynydev commented 5 months ago

this issue is now closed: https://github.com/coreos/rpm-ostree/issues/233

xynydev commented 5 months ago

Not part of the latest release, but will be able to remove optfix once rpm-ostree gets a new release and we get it on our systems. So, once version hits 2024.3 or bigger.

Mine is currently at 2023.11:

❯ rpm-ostree --version
rpm-ostree:
 Version: '2023.11'
 Git: d15b73c58879a43456d5eeeee6605f7524e9ae65
 Features:
  - rust
  - compose
  - container
  - fedora-integration
fiftydinar commented 4 months ago

This is my version since today:

❯ rpm-ostree --version
rpm-ostree:
 Version: '2024.3'
 Git: 1292241492a3476cb36515812ba4eb1f87b8742f
 Features:
  - rust
  - compose
  - container
  - fedora-integration
xynydev commented 4 months ago

My system is not yet updated, but I guess we can go ahead and remove this now, as it doesn't seem to be working correctly for all users, and newer image builds would supposedly have the newer rpm-ostree version as well.

rpm-ostree now has experimental support for installing RPMs with files in /opt and /usr/local. This can be enabled at compose time (via the opt-usrlocal-overlays switch), or client-side using https://github.com/coreos/rpm-ostree/issues/233#issuecomment-1856720559. Feedback on the approach would be greatly appreciated! https://github.com/coreos/rpm-ostree/pull/4728 (from https://github.com/coreos/rpm-ostree/releases/tag/v2024.3)

We would have to figure out how to enable the experimental support, and do that by default.

xynydev commented 2 months ago

Moving discussion from #165 .

Upstream issues to enable opt-usrlocal-overlays by default:

Both of these seem stagnant. I'll poke em a little.

xynydev commented 1 week ago

https://github.com/coreos/fedora-coreos-tracker/issues/1681 is now closed as wontfix. (it was apparently just left open for long after the matter had settled, so the latest changes regarding this were now months ago in v2024.3)

There is a way to set the existing opt thing as an environment variable for rpm-ostree: https://github.com/coreos/rpm-ostree/issues/233#issuecomment-1856720559

I think we could leave the experimental opt option off, unless optfix: is declared to be anything other than false.

fiftydinar commented 1 week ago

There is a way to set the existing opt thing as an environment variable for rpm-ostree: coreos/rpm-ostree#233 (comment)

I think we could leave the experimental opt option off, unless optfix: is declared to be anything other than false.

The issue with this is that his method only works on booted system, not in build-time. At least last time I tried.

xynydev commented 1 week ago

Ah, well, that's what I feared when I saw this comment: https://github.com/coreos/rpm-ostree/pull/4728#discussion_r1465645516

There's not much use for this feature if not available at build-time...