blue-build / modules

BlueBuild standard modules used for building your Atomic Images
Apache License 2.0
24 stars 1 forks source link

feat: Include just scripts for changing & factory-resetting user-configuration of modules #125

Closed fiftydinar closed 7 months ago

fiftydinar commented 7 months ago

Inspired from this:

https://github.com/blue-build/modules/issues/157

This would make users more aware that they can change some module options & it would make that process more intuitive and easier.

F.e.

Tricky part of this is support for operating systems other then Universal Blue. In that case, we can either install just package as a dependency if it doesn't exist, or we can make a generic bash script intended for this usage only.

Another tricky part is usage of ujust in Universal Blue instead of just, which would make our commands less universal.

Universal Blue also includes their separate config made by @HikariKnight called ugum, which makes CLI selection & quick options possible. ugum is another Universal Blue exclusive, which would make this process a bit harder. Although, ugum is bash-compatible, so it's not the hardest part.

HikariKnight commented 7 months ago

ugum is compatible with normal just as i wanted it to be self contained. ujust is just a script to make sure just always runs inside bash, since it does not work correctly in shells like fish or something

xynydev commented 7 months ago

The main issue with this I see is compatibility, ince we aim to support multiple OS base images, but ublue is the only one with an unified system for default just commands and just pre-included. This would necessitate one of the following:

Introducing just on all images might add bloat (bling✨) the user might not always want when using default-flatpaks or another module making use of this system. This would make it necessary to include an option for whether to use just in each module utilizing it, along with doing the just setup with each module required.

I'm not sure if all that is worth it for making just commands that are equivalent to doing rm -rf ... && cp -r ... or launching a pre-existing shell script.

fiftydinar commented 7 months ago

I will close this issue for now, as It's concluded that this inclusion would be complex, with small gains, due to compatibility factor.

If something changes in the future, I can reopen this issue.