search

blue-build / modules

BlueBuild standard modules used for building your Atomic Images
Apache License 2.0
22 stars 26 forks source link

fix(google-fonts): update URL #180

Closed scottames closed 3 months ago

scottames commented 3 months ago

Fixes Google fonts download url.

Fixes #179

xynydev commented 3 months ago

Thanks! Did you test your fix yet? This is possible with the source: keyword. I tested the URLs and the old URL worked in a browser (with a countdown) to download the file, while the new url downloaded a json.txt file on my phone, the contents of which I didn't check yet.

scottames commented 3 months ago

Thanks! Did you test your fix yet? This is possible with the source: keyword. I tested the URLs and the old URL worked in a browser (with a countdown) to download the file, while the new url downloaded a json.txt file on my phone, the contents of which I didn't check yet.

Good questions! I'll investigate further.

m0ngr31 commented 3 months ago

Looks like it grabs the txt file, and then the individual fonts and uses the browser to package up the zip? image When I look at the download link for the zip file, I just get this: blob:null/dc2642bc-ad4a-4dc3-85b8-b171bc0cfb4b

scottames commented 3 months ago

Looks like it grabs the txt file, and then the individual fonts and uses the browser to package up the zip? image When I look at the download link for the zip file, I just get this: blob:null/dc2642bc-ad4a-4dc3-85b8-b171bc0cfb4b

Yep, that's what I'm seeing as well. It's possible to update the module to iterate over the json and install the ttf files. Not sure if that's the best approach here.

It looks like the fonts I'm pulling are actually available as rpms, so I'll probably just remove this step altogether and install the rpms.