search

blue-build / modules

BlueBuild standard modules used for building your Atomic Images
Apache License 2.0
22 stars 26 forks source link

refactor: `akmods` possibly needs to adjust to some upstream changes #211

Closed fiftydinar closed 2 months ago

fiftydinar commented 2 months ago

https://github.com/ublue-os/akmods/issues/176

https://github.com/ublue-os/akmods/pull/171#issuecomment-2061507967

Upstream akmods refactor is not yet done, so we will see if there is anything else that needs to be done

fiftydinar commented 2 months ago

@gmpinder Since akmods is a hybrid between bash & bluebuild-cli module, those changes are also affecting you, so I'm pinging

gmpinder commented 2 months ago

Ok so it's looking like we will need to remove the version prop and just use base. But we also need to have a way to specify the need for the nvidia image.

lorduskordus commented 2 months ago

My build is failing now:

0.238 ========== Start Akmods module ==========
0.569 Installing akmods
0.572 Installing: VirtualBox
0.606 error: Handling argument /tmp/rpms/kmods/*VirtualBox*.rpm: No such file or directory (os error 2)
fiftydinar commented 2 months ago

My build is failing now:

0.238 ========== Start Akmods module ==========
0.569 Installing akmods
0.572 Installing: VirtualBox
0.606 error: Handling argument /tmp/rpms/kmods/*VirtualBox*.rpm: No such file or directory (os error 2)

This happens because Universal Blue separated akmods into akmods & akmods-extra Containerfile, to make a better separation between most frequently used akmods & community requested/made akmods.

VirtualBox akmod now resides in akmods-extra Containerfile, which we don't pull yet, but fix is easy, so this will be fixed soon.

fiftydinar commented 2 months ago

@lorduskordus Your reported issue is fixed, but usage of unstable CLI is required, until new GitHub Action gets released:

https://blue-build.org/reference/github-action/#use_unstable_cli-optional

This PR fixed it: https://github.com/blue-build/cli/pull/169

fiftydinar commented 2 months ago

All adapting akmods changes are done, but I will keep the issue open, until new BlueBuild GitHub Action gets released.

fiftydinar commented 2 months ago

Unfortunately, GH Action v1.4.0 released today uses BlueBuild CLI v0.8.4 but support for extra akmods is in v0.8.5, so I will still have to keep this issue open.

This means that usage of unstable CLI is still required.

gmpinder commented 2 months ago

Unfortunately, GH Action v1.4.0 released today uses BlueBuild CLI v0.8.4 but support for extra akmods is in v0.8.5, so I will still have to keep this issue open.

This means that usage of unstable CLI is still required.

New GHA version was released today containing those fixes