search

blue-build / modules

BlueBuild standard modules used for building your Atomic Images
Apache License 2.0
21 stars 27 forks source link

feat: Add justfiles module #270

Closed lorduskordus closed 2 days ago

lorduskordus commented 1 week ago

Users will be able to save their scripts in separate justfiles and won't have to worry about correctly importing them.

Can be especially useful for people building multiple images to have for example DE specific justfiles. GNOME specific justfiles don't end up in a KDE image, common justfiles are imported to all images,..

xynydev commented 6 days ago

Note that other ublue downstreams (bazzite) edit /usr/share/ublue-os/justfile directly: https://github.com/ublue-os/bazzite/blob/8914464dd8c654957e583c081e91ae9bcd4e4963/Containerfile#L596

lorduskordus commented 6 days ago

Note that other ublue downstreams (bazzite) edit /usr/share/ublue-os/justfile directly: https://github.com/ublue-os/bazzite/blob/8914464dd8c654957e583c081e91ae9bcd4e4963/Containerfile#L596

So should I instead use /usr/share/ublue-os/justfile as the destination file ? I don't see a problem here

xynydev commented 6 days ago

I'm not sure :woman_shrugging:... I just pointed it out since that's what ublue's doing. Both work, and the only benefit I can think of for editing /usr/share/ublue-os/justfile is that there's no nested imports and that they're all in the same place.

fiftydinar commented 6 days ago

60-custom.just is intended for downstream users like us, while /usr/share/ublue-os/justfile is originally intended for Ublue upstream images like Bazzite, Bluefin & others.

So I find this good.

lorduskordus commented 3 days ago

Am I supposed to do anything else here ?

fiftydinar commented 3 days ago

Am I supposed to do anything else here ?

@lorduskordus In my opinion, no. Everything's looking good. We just need to wait for @xynydev to approve or request for any needed changes & then we can merge this.