blue-build / modules

BlueBuild standard modules used for building your Atomic Images
Apache License 2.0
24 stars 25 forks source link

issue with dconf-update-service module #34

Closed zelikos closed 11 months ago

zelikos commented 11 months ago

I'm porting my custom image over to the new modular startingpoint base, and ran into this issue that led to a failed build:

Pulling from bling: dconf-update-service

Failed to enable unit, unit dconf-update.services.service does not exist.

I think the problem may be this line? https://github.com/ublue-os/bling/blob/911ed35367190f4825b6e96b75d06d4da000148f/modules/bling/installers/dconf-update-service.sh#L7

systemctl enable dconf-update.services should instead be systemctl enable dconf-update.service, IIUC

lorduskordus commented 11 months ago

36

lorduskordus commented 11 months ago

@xynydev I believe the issue here is systemctl expects the service in /etc, not /usr/etc. The service gets copied to /etc only after booting the image, so it doesn't see it in the building phase and says it doesn't exist. I did some tests with the systemd module and it behaves the same way. (/etc works, /usr/etc doesn't)

zelikos commented 11 months ago

The service file can also be in /usr/lib, i.e. /usr/lib/systemd/system/servicefile.service; that's how I had things set up before trying to switch to the module here (and what I went back to after the build issue mentioned in the op). Bazzite places service files in /usr/lib as well

dperson commented 11 months ago

I still got the original error when starting a fresh build with the dconf-update-service module enabled.

zelikos commented 11 months ago

I still got the original error when starting a fresh build with the dconf-update-service module enabled.

The published bling image is from 17 hours ago, so I assume the fixes aren't live just yet

lorduskordus commented 11 months ago

Yep, just wait until the next bling image gets built (5am UTC), then it should work, I tested it locally.

dperson commented 11 months ago

Okay, I missed the implementation detail that it used an image of bling repo, and we had to wait on it to build. Thanks for the clarification, and fixing it!