search

blue-build / modules

BlueBuild standard modules used for building your Atomic Images
Apache License 2.0
24 stars 25 forks source link

feat: flatten fonts in /usr/share/fonts for distrobox #59

Closed nhubaotruong closed 10 months ago

nhubaotruong commented 10 months ago

Fixes https://github.com/ublue-os/bling/issues/58

xynydev commented 10 months ago

IIRC some line in the fonts module wipes the directory before downloading there(?). This should be checked too. I wasn't aware that nested font directories wouldn't always be supported. It might be worth investigating if there's another way to do this, since with the nesting the structure is cleaner. I don't have a lot of time rn, sorry, not merging yet. Someone else can feel free to do a review of this PR.

nhubaotruong commented 10 months ago

Hi I'm back, I was meant to do that, add a prefix to indicate nerd font or google font in case it gets duplicated.

I was also thinking that it would be better to just put all nerd fonts and google fonts in 1 folder instead of nested

Ex: /usr/share/fonts/nerd-fonts/*.ttf

lucasvsr commented 10 months ago

Hi I'm back, I was meant to do that, add a prefix to indicate nerd font or google font in case it gets duplicated.

I was also thinking that it would be better to just put all nerd fonts and google fonts in 1 folder instead of nested

Ex: /usr/share/fonts/nerd-fonts/*.ttf

Ok, in this case it will be necessary to change the logic in the download script a little, which validates whether the directory is empty and then downloads the fonts.

nhubaotruong commented 10 months ago

Hi, I've updated

lucasvsr commented 10 months ago

Hi, I've updated

You still need to adjust download.sh, which still validates whether the directory is empty and then downloads it. In the first execution of the loop it will download the source, but from the second it will not do so as the directory is filled.

nhubaotruong commented 10 months ago

Close as explained in the issue ticket