Font module: Not specifying a nerd-font makes the module fail.

[AuraHerreroRuiz]

I tried to use the module to only download google fonts, and I tried multiple ways, like not having the nerd-fonts key in the yaml:

type: fonts
fonts:
  google-fonts:
    - Atkinson Hyperlegible
    - Cormorant Garamond

Or by having it "empty":

type: fonts
fonts:
  google-fonts:
    - Atkinson Hyperlegible
    - Cormorant Garamond
  nerd-fonts:

Both make my ublue image fail to build, trying to download a zip file with no name:

=== Launching module of type: fonts ===
Installation of google-fonts started
Downloading Atkinson Hyperlegible.zip
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  121k    0  121k    0     0   727k      0 --:--:-- --:--:-- --:--:--  730k
Warning: Got more output options than URLs
Archive:  Atkinson Hyperlegible.zip
  inflating: /usr/share/fonts/google-fonts/Atkinson Hyperlegible/OFL.txt  
  inflating: /usr/share/fonts/google-fonts/Atkinson Hyperlegible/AtkinsonHyperlegible-Regular.ttf  
  inflating: /usr/share/fonts/google-fonts/Atkinson Hyperlegible/AtkinsonHyperlegible-Italic.ttf  
  inflating: /usr/share/fonts/google-fonts/Atkinson Hyperlegible/AtkinsonHyperlegible-Bold.ttf  
  inflating: /usr/share/fonts/google-fonts/Atkinson Hyperlegible/AtkinsonHyperlegible-BoldItalic.ttf  
Atkinson Hyperlegible.zip downloaded
Downloading Cormorant Garamond.zip
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 1514k    0 1514k    0     0  3687k      0 --:--:-- --:--:-- --:--:-- 3684k
Warning: Got more output options than URLs
Archive:  Cormorant Garamond.zip
  inflating: /usr/share/fonts/google-fonts/Cormorant Garamond/OFL.txt  
  inflating: /usr/share/fonts/google-fonts/Cormorant Garamond/CormorantGaramond-Light.ttf  
  inflating: /usr/share/fonts/google-fonts/Cormorant Garamond/CormorantGaramond-LightItalic.ttf  
  inflating: /usr/share/fonts/google-fonts/Cormorant Garamond/CormorantGaramond-Regular.ttf  
  inflating: /usr/share/fonts/google-fonts/Cormorant Garamond/CormorantGaramond-Italic.ttf  
  inflating: /usr/share/fonts/google-fonts/Cormorant Garamond/CormorantGaramond-Medium.ttf  
  inflating: /usr/share/fonts/google-fonts/Cormorant Garamond/CormorantGaramond-MediumItalic.ttf  
  inflating: /usr/share/fonts/google-fonts/Cormorant Garamond/CormorantGaramond-SemiBold.ttf  
  inflating: /usr/share/fonts/google-fonts/Cormorant Garamond/CormorantGaramond-SemiBoldItalic.ttf  
  inflating: /usr/share/fonts/google-fonts/Cormorant Garamond/CormorantGaramond-Bold.ttf  
  inflating: /usr/share/fonts/google-fonts/Cormorant Garamond/CormorantGaramond-BoldItalic.ttf  
Cormorant Garamond.zip downloaded
Installation of nerd-fonts started
Downloading .zip
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

100     9  100     9    0     0     33      0 --:--:-- --:--:-- --:--:--    33
Warning: Got more output options than URLs
Archive:  .zip
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of .zip or
        .zip.zip, and cannot find .zip.ZIP, period.
[2/5] STEP 1/3: FROM fedora: AS synaTudor
error building at STEP "RUN chmod +x /tmp/build.sh && /tmp/build.sh &&         rm -rf /tmp/* /var/*": error while running runtime: exit status 9
time="2023-10-10T21:50:44Z" level=error msg="exit status 9"
Error: Error: buildah exited with code 9

[xynydev]

Thanks for this report, I'll look into it ASAP.

[lucasvsr]

Thanks for this report, I'll look into it ASAP.

I had some free time and found the problem. PR open for review.

[AuraHerreroRuiz]

Thank you for the quick fix!

However I have to mention that I had to add an empty nerd-fonts: key in order for the module to work, like so:

type: fonts
fonts:
  google-fonts:
    - Atkinson Hyperlegible
    - Cormorant Garamond
  nerd-fonts:

If this is intended behavior, I think stating so in the documentation would save confusion.

[lucasvsr]

Thank you for the quick fix!

However I have to mention that I had to add an empty nerd-fonts: key in order for the module to work, like so:

type: fonts

fonts:

  google-fonts:

    - Atkinson Hyperlegible

    - Cormorant Garamond

  nerd-fonts:

If this is intended behavior, I think stating so in the documentation would save confusion.

No. There is no need to include an entry where there will be no fonts to install. If you want to install just google-fonts, ok. The same applies to nerd-fonts. Is there still a bug happening?

[xynydev]

Note that the build of ublue-os/bling that includes these fixes I think might have landed just four hours ago. If there's a bug still happening, please reopen this issue.

[AuraHerreroRuiz]

Note that the build of ublue-os/bling that includes these fixes I think might have landed just four hours ago. If there's a bug still happening, please reopen this issue.

Apologies, that was indeed the issue, the bug is fixed.