blue-build / modules

BlueBuild standard modules used for building your Atomic Images
Apache License 2.0
23 stars 25 forks source link

CPU frequency limits are too slow (tlp) #78

Closed Sadoon-AlBader closed 5 months ago

Sadoon-AlBader commented 7 months ago

https://github.com/secureblue/secureblue/issues/109

Haswell laptop with SecureBlue:

cat /sys/devices/system/cpu/cpufreq/policy0/scaling_max_freq 900000

Haswell laptop with Fedora Kinoite:

cat /sys/devices/system/cpu/cpufreq/policy0/scaling_max_freq 3000000

Same with my Alder Lake laptop, which should boost to 4.7GHz but is limited to 2.1 This is an issue across all cpufreq governors, I've tested them all :') I wouldn't have noticed had I not tried to use my Haswell laptop, which is horrendously slow at 900MHz.

CPU_MAX_PERF_ON_BAT=30 Is just too low for most laptops, especially older ones that can't clock to at least ~1.6GHz with 30%

xynydev commented 7 months ago

Ok, is there something you want to do about this? Keep in mind that bling is for optional parts for custom images, config is for main images.

Sadoon-AlBader commented 7 months ago

Ok, is there something you want to do about this? Keep in mind that bling is for optional parts for custom images, config is for main images.

Even if optional, a more sensible default would be

CPU_MAX_PERF_ON_BAT=70

Instead of 30, huge improvement that makes the laptop much more usable but still conserves energy and limits heat output.

qoijjj commented 7 months ago

FYI, this might actually be buggy and not just a question of preference:

Error in configuration at INTEL_GPU_MIN_FREQ_ON_AC="100": frequency invalid or out of range (see 'tlp-stat -g').

(for a card with 360mhz min)

tulilirockz commented 5 months ago

Hi! It was me that made that "laptop" option. I just copied the whole TLP config from the ublue-os/framework configs. Maybe having that as a general option wouldnt be great. We could just split the laptop option onto: laptop-framework laptop-asus and laptop options with each of them with their own frequencies and everything

tulilirockz commented 5 months ago

This issue was addressed on https://github.com/ublue-os/bling/commit/85d3b6b8fd365b22dd8b343b1918b44454630833

I hope this is a better configuration for you all, if not, please make another issue or just comment on this one!