search

blue-build / modules

BlueBuild standard modules used for building your Atomic Images
Apache License 2.0
23 stars 25 forks source link

fix(default-flatpaks): Dont install packages that are already present #80

Closed fiftydinar closed 7 months ago

fiftydinar commented 7 months ago

... or remove packages that aren't there.

By @EyeCantCU

Took from Bazzite.

Please check if I did changes correctly.

fiftydinar commented 7 months ago

We should revert this, as in this current implementation, it will always write "1" to the system-flatpak-configured & to user-flatpak-configured, even if it's not configured. Just tested this in VM.

I see that in Bazzite's & Bluefin's implementation, you manually change the version file (from 1 to 2, from 2 to 3 etc.) But here, it will always write "1", as it assumes that it's configured forever. Only deleting the "system-flatpak-configured" & "user-flatpak-configured" file manually is going to trigger the setup again, as documented in module's README. Version changing is something that should be implemented automatically whenever you make a change.

xynydev commented 7 months ago

I don't see what this PR has got to do with system-flatpak-configured & to user-flatpak-configured, that existed before and this is just checking if the flatpaks are installed/not installed before installing/removing. But there's a revert button right there I (and maybe you too?) can press if this is the correct PR to revert.