blue-build / modules

BlueBuild standard modules used for building your Atomic Images
Apache License 2.0
24 stars 1 forks source link

chore: force create firstboot symlink in yafti module #82

Closed miabbott closed 9 months ago

miabbott commented 9 months ago

I switched my custom ublue image from using "ublue-os/silverblue-nvidia" to "ublue-os/bazzite-gnome-nvidia" and received the following error when the build action kicked off:

ln: failed to create symbolic link '/usr/etc/profile.d/ublue-firstboot.sh': File exists

The yafti module should be the only thing creating this symlink, so it should be safe to use the -f flag to force creating it.

xynydev commented 9 months ago

We can't control what is in the symlink beforehand. I mean, I guess it's usually the correct thing, but would it be safer to just override it always?

miabbott commented 9 months ago

We can't control what is in the symlink beforehand. I mean, I guess it's usually the correct thing, but would it be safer to just override it always?

Sure, I'll modify the patch to copy any old version to <file>.old and create the new symlink.

miabbott commented 9 months ago

Sure, I'll modify the patch to copy any old version to <file>.old and create the new symlink.

Eh, it doesn't make sense to copy an old version of the symlink...I'll just force create it