search

blue-build / modules

BlueBuild standard modules used for building your Atomic Images
Apache License 2.0
23 stars 25 forks source link

(yafti) how to handle the installation of `ublue-firstboot.sh` #84

Closed miabbott closed 5 months ago

miabbott commented 7 months ago

I was trying to clean up an error in the yafti bling module (https://github.com/ublue-os/bling/pull/82) and became puzzled by how everything is wired together.

The logic in the yafti module assumes the presence of /usr/share/ublue-os/firstboot/launcher/login-profile.sh, but that file does not seem to be universally included in all image variants. This could result in an user trying to use the yafti module in their custom image and getting unexpected results.

Should the yafti module ship a version of login-profile.sh by default?

The Bazzite image provides a version of login-profile.sh, as does the startingpoint image ...and they have the same content. However, those seem to be the exception rather than the rule.

cc: @xynydev @castrojo

xynydev commented 6 months ago

Sorry, this issue had flown completely under my radar. Currently startingpoint does depend on some bling components and bling on some of startingpoint's files. This is a known issue, and will be fixed un-urgently.

miabbott commented 6 months ago

@xynydev Understood. If I can help untangling the dependencies of the two projects, please let me know.