search

blue-build / modules

BlueBuild standard modules used for building your Atomic Images
Apache License 2.0
23 stars 25 forks source link

feat(default-flatpaks): Add info about which flatpaks are installed #85

Closed fiftydinar closed 6 months ago

fiftydinar commented 6 months ago

...& uninstalled in notification. Also implement notification enable/disable config support.

Only supports up to 5 flatpak entries (when hovered on mouse), as 6 lines are the limit for the expanded notification on Gnome. Gnome does not support expanded notifications in notification center.

Screenshot from 2023-12-21 01-38-07 Screenshot from 2023-12-21 01-37-53

Interestingly, when using Expandable Notifications Gnome extension, it supports up to 16 flatpak entries (17 lines) in notification center when expanded.

Screenshot from 2023-12-21 01-39-04 Screenshot from 2023-12-21 01-38-36

I don't know how is the situation on other DE's regarding notifications line support.

Took some idea from myself here: https://github.com/ublue-os/bling/pull/83#discussion_r1432744685

fiftydinar commented 6 months ago

Edit: I will mark this as ready, this stuff can be implemented in other PR if needed.

I need help on implementing notifications config modifying support in recipe file & in default-flatpaks.sh module. Currently, it just enables notifications by default. It would be good to have this option in recipe file too to be built in a container, not just in post install of the OS in form of just file or similar.

xynydev commented 6 months ago

I need help on implementing notifications config modifying support in recipe file & in default-flatpaks.sh module.

Use yq ".notify" "$CONFIG_FILE" to get the config value from the recipe (should return true or false, or something else if there is a configuration error or the key is not specified, in which case it should probably default to true).

Then add this in the example configs right under type: or at the bottom, whichever you find better. Add a comment like # Send notification after install/uninstall is finished right next to it.

fiftydinar commented 6 months ago

I need help on implementing notifications config modifying support in recipe file & in default-flatpaks.sh module.

Use yq ".notify" "$CONFIG_FILE" to get the config value from the recipe (should return true or false, or something else if there is a configuration error or the key is not specified, in which case it should probably default to true).

Then add this in the example configs right under type: or at the bottom, whichever you find better. Add a comment like # Send notification after install/uninstall is finished right next to it.

I hope I did well, since this is the 1st time I work with module sh script.

fiftydinar commented 6 months ago

Fixed