search

blue-build / modules

BlueBuild standard modules used for building your Atomic Images
Apache License 2.0
23 stars 25 forks source link

fix(default-flatpaks): Missing notification for system flatpaks #87

Closed fiftydinar closed 6 months ago

fiftydinar commented 6 months ago

This approach, while more fragmented, it's cleaner, as there is a clearer separation of root & non-root operations done by flatpak-setup service. This should probably increase security too (but I'm not the expert to talk seriously about that). It also gets rid of some non-harming error for /var data, can't remember it fully.

I fiddled with getting correct DBUS session & exporting it as a temporary environment variable, but I failed in multiple cases. Notify-send requires this workaround when ran as root, hence why I looked into this approach. But even If I succeeded with that, I think that this PR approach is better.

While it may be confusing for users that they have to type:

systemctl status --user system-flatpak-setup

instead of previous:

systemctl status system-flatpak-setup

It is something worth sacrificing for the important user-experience fix.

xynydev commented 6 months ago

Thanks! If I don't merge this today I'll look more into it after christmas.