search

blue-build / template

Template for making your own OS image using BlueBuild
Apache License 2.0
109 stars 13 forks source link

PR GitHub action build: two builds intended? #28

Open plata opened 4 months ago

plata commented 4 months ago

In a pull request, the GitHub action runs twice (for push and for pull request): checks Is this intended?

xynydev commented 4 months ago

If you are doing a PR from your own repository, I guess, since it is intended that both internal branches without PRs and external PRs without internal branches run a build. I guess one of those could be disabled in the action, though.

plata commented 4 months ago

If you agree to have the push build only on branch main, I can open a PR for it.

xynydev commented 4 months ago

No, it is intended that pushes happen on all branches and on PRs. It can be considered a bug or and edge case than on an in-repo PR both builds are triggered, and a PR mitigating that would be merged.

plata commented 4 months ago

This doesn't seem to be easy to achieve with the current workflow syntax. This proposal would help.

The only possibility apparently is a conditional implementation per job: https://github.com/orgs/community/discussions/57827.

However, if the build runs for every push anyway, why would you even want to have the pull_request trigger as well? Is there any possibility to create a pull request change without a push?

xynydev commented 4 months ago

However, if the build runs for every push anyway, why would you even want to have the pull_request trigger as well? Is there any possibility to create a pull request change without a push?

Yes, it is. push only runs if the push is into the repository, while pull_request also triggers on PRs from forks.

The only possibility apparently is a conditional implementation per job: https://github.com/orgs/community/discussions/57827.

That is not only the only possibility, but the best one. The action in this repository only has a single job with a single step, so no repetition would be needed.