`--testing` flag does not prevent overwriting of result files

blue-marble / gridpath

A versatile simulation and optimization platform for power-system planning and operations.

https://www.gridpath.io

Apache License 2.0

95 stars 36 forks source link

`--testing` flag does not prevent overwriting of result files #765

Open milindsmart opened 3 years ago

milindsmart commented 3 years ago

gridpath_run has the --testing flag which should suppress saving of results https://github.com/blue-marble/gridpath/blob/8a8042b667ff19aea3f283bd41f56e484af5ce92/gridpath/common_functions.py#L173-L174

However, scenario results are saved and the test results for verification are overwritten. run_scenario.py does not seem to have any branching logic for this flag.

anamileva commented 3 years ago

Yep, this should have been removed from the help menu as it's not hooked up anywhere at this point. I see there are still some references to "testing mode" in run_scenario.py, which should also be clarified.

milindsmart commented 3 years ago

I feel this is still useful functionality to have, FWIW. Currently the example test values to be compared and checked are within the test script itself, maybe it can read from the result files?