search

blue-nebula / base

Main repository of Blue Nebula, a fast-paced shooter with a unique parkour system. It is a fork of Red Eclipse and is free software.
https://blue-nebula.org
15 stars 6 forks source link

Simplify skin functions #210

Open robalni opened 3 years ago

robalni commented 3 years ago

This change makes the code easier to read. It changes behaviour of drawskin slightly; now it stretches the image instead of repeating it but that should not be visible with default skin.

MoonPadUSer commented 3 years ago

Isn't the drawskin() function supposed to use some kind of 9-split and repeat it based on that? Instead of just plain stretching/repeating

robalni commented 3 years ago

Yes, it still splits it in 9. It's just the center piece that is stretched now instead of repeated.

MoonPadUSer commented 3 years ago

I think that's not how you're supposed to do that, ideally it repeats it so it can give ideal results

robalni commented 3 years ago

Doesn't that just depend on what skin you have? Some skins look better stretched and some repeated.

MoonPadUSer commented 3 years ago

yeah, but usually you design your skins in a way so they look the best when repeated, e.g. if you have a low-res skin, stretched will make it look very pixelated