Fix some warnings and general cleanup - Githubissues

blue-nebula / base

Main repository of Blue Nebula, a fast-paced shooter with a unique parkour system. It is a fork of Red Eclipse and is free software.

https://blue-nebula.org

15 stars 6 forks source link

Fix some warnings and general cleanup #248

Open voidanix opened 2 years ago

voidanix commented 2 years ago

Initialize x, y, z inside vec
Remove volatile keyword from errors counter
Clear objects of now trivial type
Fix possible uninitialization of height
Convert weapon selection system to std::vector
Fix -Wnon-pod-varargs error on clang 14
Fix -Wint-in-bool-context
Document what the sound enums actually are
Fix unneeded parenthesis
Fix uninitialized values in md3 structs
Fix comparison between different signedness
Fix address of array always returning true
Remove set but unused variables
Fix implicit conversion between float and int
Fix shift with negative value
Attempt to fix misleading indentation warning

voidanix commented 2 years ago

Thanks for the reviews @TheAssassin and @robalni ! Updated the branch

voidanix commented 1 year ago

FYI the inrange function now uses constexpr (it will be reused in a later refactor) and the custom NULL macro has been removed

voidanix commented 1 year ago

Ping, any updates on this?