search

blue-nebula / base

Main repository of Blue Nebula, a fast-paced shooter with a unique parkour system. It is a fork of Red Eclipse and is free software.
https://blue-nebula.org
18 stars 7 forks source link

keybinding in menu is a nightmare #265

Open Lagetta opened 1 year ago

Lagetta commented 1 year ago

Observation: Tried to recreate this issue exactly on linux and windows 11 latest version.

by using keybinding menu, I should be able to easily change desired keybindings. If i decided on the button, I should be able to to set it on ESC.

If I do a mistake like pressing too many buttons, by instinct, I can click the desired button, press ESC to remove all of the keybindings and try to set them again from scratch.

However this is REALLY inefficient way to set keys. What happens is that when you try to set the keys and press ESC, the same keybindings are shown. If you try to set other keys when pressing a key, you get additional keys on top of the added keys.

You can actually by mistake set so many keys, that's it's just better to start from scratch. However if you try to restore all default keybindings, only those that are in the default list get to their desired spots. Other non-default keys stay on the same keybinding.

For example (what happened to me basically):

  1. I want to change keybinding for weap slot 1, the default keybinding is 2.
  2. I press on the window, I get empty space.
  3. I press any key to set it.
  4. I accidentally press Enter to set it, but instead I get <any key> RETURN.
  5. Pressing ESC, my keys that are set are <any key> 2 RETURN.

At this point, I want to remove my mistake and try to remove RETURN key.

  1. Pressing again that same window I get empty space.
  2. Pressing ESC to cancel all the keys.
  3. Still seeing same keys.

Basically this didn't do anything. Will try to set it to other key to try to think that I want to do this from scratch.

  1. Pressing ESC to see black window.
  2. pressing other <any key> let's say for this example 4 for weap slot 3.
  3. weap slot 3 loses a key and weap slot 1 gets keys <any key> 4 RETURN, 2

At this point, I want to restart.

  1. Pressing restore all default key binds and clicking YES, continue
  2. only part of the keys are back to their original places in this case: weap slot 3 4 key. So I am left with <any key> RETURN 2. (which is weird, that RETURN doesn't go back to it's original keybinding, but it must be because it's not even on this menu list, even though in the vanilla game, it acts as chat)

I can't really explain it well enough to be understandable on a text, so I really suggest trying to set keybindings from that menu and you'll see my point. It's easy out of frustration click so many keys, that you break all the keybindings in the game.

I think this menu should even be rewritten entirely or improved so much that it's more user friendly. My suggestions: There should be some kind of warning telling you that you are binding the key that is already bound. (IMPORTANT) There should be some kind of clickable onscreen symbol to add/edit/delete all keybindings. (This will make the process of setting keys way easier) There should be a mini symbol before the keybinding window when clicking to set it to default. (Restoring all default keybindings is just too drastic if you already set more than one key correctly) Optional: Add color indicator which buttons are changed by the user. (It's easier for the eye to spot the changes)

Lagetta commented 1 year ago

I also found that while trying to set the keys to it's default settings, by clicking restore all default key binds it shows this menu: image it clearly states in the first sentence that it's about to restore Red Eclipse Legacy default keyboard binds.