blue-systems / netrunner-core-releases

Core releases based on Debian stable
0 stars 0 forks source link

Systemsettings kservices need update (broken modules) #7

Closed llelectronics closed 5 years ago

llelectronics commented 6 years ago

Systemsettings look a bit weird with the "old" icon view (too many catgeories and some icons look out of place). Fonts & Font Settings which includes Fonts module for example. Some modules are not working/accessible like Workspace Behavior -> Workspace.

NuLogicSystems commented 6 years ago

I already updated this in github for Plasma 5.13. If your still packaging for 5.12.x, you'll need to use the prior commit from February. https://github.com/ds9-common/default-systemsettings-settings/commits/master

llelectronics commented 6 years ago

We are packaging for Plasma 5.8 now in Netrunner Core :P

NuLogicSystems commented 6 years ago

Hmm, I'm not that familiar with Debian packaging. Can you not cherry pick during packaging?

I do apologize, I was just trying to do as I was instructed.

llelectronics commented 6 years ago

We could do a configuration especially for Plasma 5.8 but I think starbuck wants it also to live in a separate git repo then. So we'll see.

NuLogicSystems commented 6 years ago

Well, systemsettings for Rolling is also in a separate git repo, but I was asked to "see if you can copy them over to the netrunner debian repos."

On retrospect, maybe I should have made a separate branch for these upstream changes to Plasma 5.13.

llelectronics commented 6 years ago

It is not your fault at all. We made the decision for Netrunner Core to use Debian stable as base instead of testing. This means instead of Plasma 5.13 -> Plasma 5.8. Though we still have Plasma 5.13 for the "normal" Netrunner version (the non core one) so that it is very useful to have those changes for it. As we just started basically on Netrunner Core development. I added this task purely as reminder that we don't forget to fix stuff with systemsettings.

NuLogicSystems commented 6 years ago

Just a thought , but couldn't you just pull from the netrunner/18.03 branch? It's at the commit right before I made those changes.

llelectronics commented 6 years ago

We'll see. I am not convinced that this will even work with Plasma 5.8. But that needs testing first.

shadeslayer commented 6 years ago

We can potentially ship the customised version of the desktop file in the netrunner-core specific settings path?

llelectronics commented 6 years ago

Yes we can do this. We just need to make sure it is prioritized over the ds9 one

shadeslayer commented 6 years ago

Everything in usr/share/netrunner-core-settings/plasma5-profile/ is prioritised over usr/share/default-settings/plasma5-profile/