search

blue-systems / netrunner-issues-old

Todos for Netrunner Desktop Releases
0 stars 0 forks source link

samba-mounter: on ssd, the previous connections do not re-establish themselves anymore after reboot #150

Open star-buck opened 5 years ago

star-buck commented 5 years ago

@davidedmundson : any idea how to make sure samba-mounter connections establish themselves again correctly, because thats the whole idea of permamount them in the fstab?

Can we add something in samba-mounter or can @llelectronics do anything in netrunner configs?

davidedmundson commented 5 years ago

I took a look. The code doesn't actually save anything in fstab. Instead on login samba-mounter starts up and mounts everything from the local config it has when it finds the network changes.

The end result should be the same, mounted dirs on boot - which somehow we're apparently not getting here.

I re-read the code, nothing immediately looked wrong, and I couldn't immediately reproduce it when trying.

Can you think of any other differences that the SSD machine has that might help me narrow this down?

adriaandegroot commented 5 years ago

Freshly installed Netrunner 19.01 (at least, grub says 19.01 and I think I used the 1230 ISO). Installed in VirtualBox.

adriaandegroot commented 5 years ago

After entering first SMB settings, before OK

screenshot_20190103_171703

First share created

screenshot_20190103_172031

Second share created

screenshot_20190103_172402

After reboot

screenshot_20190103_172645

star-buck commented 5 years ago

Good find, potentially chinmoy could have a look. On Jan 3, 2019 17:29, "Adriaan de Groot" notifications@github.com wrote:

After entering first SMB settings, before OK

[image: screenshot_20190103_171703] https://user-images.githubusercontent.com/19431457/50648972-ec84d380-0f7c-11e9-8e11-7dc0106f45ce.png First share created

[image: screenshot_20190103_172031] https://user-images.githubusercontent.com/19431457/50648974-edb60080-0f7c-11e9-8690-63bc439bef2b.png Second share created

[image: screenshot_20190103_172402] https://user-images.githubusercontent.com/19431457/50648975-edb60080-0f7c-11e9-87ee-d2d4edc8648f.png After reboot

[image: screenshot_20190103_172645] https://user-images.githubusercontent.com/19431457/50648977-ee4e9700-0f7c-11e9-9cfe-096016854740.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/blue-systems/netrunner-releases/issues/150#issuecomment-451197232, or mute the thread https://github.com/notifications/unsubscribe-auth/AAzRhm3XzoPIIao01t7QC7irLO_NC4zsks5u_i_9gaJpZM4ZlEZb .

adriaandegroot commented 5 years ago

Well, the screenshots (desktop background and theme) should have been a hint that I was using Idolon, not Blackbird. In any case, I have re-tested with Blackbird, and part of the problem here is that the UI is less-than-intuitive to me (as someone who has never mounted a Samba share using KDE tools before). When used correctly, it does work. I now have two entries in samba-mounter and both are (re)mounted on boot.

Here's the Dolphin window, with the two folders inside. I know that both are mounted.

screenshot_20190103_225755

Doubleclick on the Add Network Drive icon. It pops up the .. whatever, KCM module.

screenshot_20190103_225916

Things that are wrong here:

star-buck commented 5 years ago

6 years of using the app almost daily, i dont even notice these shortcomings anymore :)

Agreed that the New/Add mechanism is improvable (its similar though for a few kcms).

star-buck commented 5 years ago

But once it works i found this an awesome improvement of having those remotes samba shares available equally well as if local (also as added gtk filedialogs entries in sidebar, etc.). On Jan 3, 2019 23:07, "Adriaan de Groot" notifications@github.com wrote:

Well, the screenshots (desktop background and theme) should have been a hint that I was using Idolon, not Blackbird. In any case, I have re-tested with Blackbird, and part of the problem here is that the UI is less-than-intuitive to me (as someone who has never mounted a Samba share using KDE tools before). When used correctly, it does work. I now have two entries in samba-mounter and both are (re)mounted on boot.

Here's the Dolphin window, with the two folders inside. I know that both are mounted.

[image: screenshot_20190103_225755] https://user-images.githubusercontent.com/19431457/50663801-28369200-0fab-11e9-8997-e34ffe607515.png

Doubleclick on the Add Network Drive icon. It pops up the .. whatever, KCM module.

[image: screenshot_20190103_225916] https://user-images.githubusercontent.com/19431457/50663859-59af5d80-0fab-11e9-8278-9610d0c1c6d9.png

Things that are wrong here:

  • the existing mount is selected, not the new share. So if I naively enter new credentials, believing that I've just clicked on Add, I'm actually editing the existing mount. I thought it had semi-conveniently filled in some values. So that is why I only got one share previously: I never added a second one! If I now click on the new share icon, then I get blank fields and can fill in a new share.
  • the existing shares are labeled as on the , which is less-than-useful.
  • there are no translations for this module; I installed in German (you can tell by the surrounding buttons).
  • there is an auto-complete / auto-suggestion for the name of the share. But it only takes the first letter of the share name into account .. as I type in smb://hostname.domain.org/Zusammen http://hostname.domain.org/Zusammen. as soon as I type the Z (starting the name of the share, after the hostname) the field is filled in with Z and then doesn't follow the rest of the name I type in. This is inconvenient -- it's probably doing "is field empty then use name of share" to auto-suggest, which is doomed while typing.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/blue-systems/netrunner-releases/issues/150#issuecomment-451292981, or mute the thread https://github.com/notifications/unsubscribe-auth/AAzRhjUcVm-hoTQz7IieGpVFxqvIFLkEks5u_n8ugaJpZM4ZlEZb .

davidedmundson commented 5 years ago

I've fixed it so that having a shortcut to "New Share" will pre-select the "New Share" entry. Netrunner will need to change their shortcut .desktop file to say "Exec=kcmshell5 sambamount --args --new" instead of their current Exec line.

I've also fixed a hypothetical case where we maybe wouldn't mount a network drive, but I can't say if it'll make an impact on whatever the case here is.