search

blue-systems / netrunner-issues-old

Todos for Netrunner Desktop Releases
0 stars 0 forks source link

DCI: Reminder: stop hacks like these #168

Open star-buck opened 5 years ago

star-buck commented 5 years ago 
root@do-dci-imager:~/build/live-build# cat customization/hooks/live/05-download-software-properties-fix.hook.chroot
echo "I: Download and Install Software Properties Fix"
mkdir -p /tmp/ssf
wget http://de.archive.ubuntu.com/ubuntu/pool/main/s/software-properties/python3-software-properties_0.96.24.32.6_all.deb -O /tmp/ssf/python.deb
wget http://de.archive.ubuntu.com/ubuntu/pool/main/s/software-properties/software-properties-common_0.96.24.32.6_all.deb -O /tmp/ssf/common.deb
wget http://de.archive.ubuntu.com/ubuntu/pool/universe/s/software-properties/software-properties-kde_0.96.24.32.6_all.deb -O /tmp/ssf/kde.deb
apt-get -y install /tmp/ssf/*.deb;
apt-get install -y -f
rm -r /tmp/ssf
shadeslayer commented 5 years ago

A more proper workflow would have been to poke the debian maintainer, fork the source and rebuild on DCI while we wait for a fix.

If DCI is broken, then it should be fixed for package building instead of doing random wget's and apt installs.

shadeslayer commented 5 years ago

As expected, this code is now broken because the debs are gone :

I: Download and Install Software Properties Fix
--2019-01-11 17:13:08--  http://de.archive.ubuntu.com/ubuntu/pool/main/s/software-properties/python3-software-properties_0.96.24.32.6_all.deb
Resolving de.archive.ubuntu.com (de.archive.ubuntu.com)... 141.30.62.23, 141.30.62.24, 141.30.62.22, ...
Connecting to de.archive.ubuntu.com (de.archive.ubuntu.com)|141.30.62.23|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2019-01-11 17:13:09 ERROR 404: Not Found.

--2019-01-11 17:13:09--  http://de.archive.ubuntu.com/ubuntu/pool/main/s/software-properties/software-properties-common_0.96.24.32.6_all.deb
Resolving de.archive.ubuntu.com (de.archive.ubuntu.com)... 141.30.62.23, 141.30.62.24, 141.30.62.22, ...
Connecting to de.archive.ubuntu.com (de.archive.ubuntu.com)|141.30.62.23|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2019-01-11 17:13:09 ERROR 404: Not Found.

--2019-01-11 17:13:09--  http://de.archive.ubuntu.com/ubuntu/pool/universe/s/software-properties/software-properties-kde_0.96.24.32.6_all.deb
Resolving de.archive.ubuntu.com (de.archive.ubuntu.com)... 141.30.62.23, 141.30.62.24, 141.30.62.22, ...
Connecting to de.archive.ubuntu.com (de.archive.ubuntu.com)|141.30.62.23|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2019-01-11 17:13:09 ERROR 404: Not Found.
shadeslayer commented 5 years ago

I noticed yet another workaround https://github.com/netrunner-desktop/live-build/blob/master/customization/hooks/live/04-workaround-cala-libpythonqt.hook.chroot

Again, I would like a explanation why the package wasn't rebuilt through DCI?