search

blue-systems / netrunner-issues-old

Todos for Netrunner Desktop Releases
0 stars 0 forks source link

FF: Bookmarks cannot be deleted, or they will re-appear after every new start #169

Open star-buck opened 5 years ago

star-buck commented 5 years ago

this looks like a hacky way to force bookmarks that forces it over any user edit...

NuLogicSystems commented 5 years ago

Fixed with this commit: https://github.com/netrunner-rolling/netrunner-settings-firefox/commit/69a557ef2499420a767d0556ba92af0cac8e0309

star-buck commented 5 years ago

If we update our package, can anyone benefit from this without loosing bookmarks? On Jan 13, 2019 18:29, "James Kittsmiller" notifications@github.com wrote:

Fixed with this commit: netrunner-rolling/netrunner-settings-firefox@69a557e https://github.com/netrunner-rolling/netrunner-settings-firefox/commit/69a557ef2499420a767d0556ba92af0cac8e0309

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/blue-systems/netrunner-releases/issues/169#issuecomment-453849053, or mute the thread https://github.com/notifications/unsubscribe-auth/AAzRhsdC4lPFHU_Prc_aUnKiQEssDy4kks5vC20QgaJpZM4Z84b3 .

star-buck commented 5 years ago

We also have to be careful not to update to live S3 from dci now that RC is out. On Jan 13, 2019 20:55, "Clemens Toennies" starbuck@netrunner-os.com wrote:

If we update our package, can anyone benefit from this without loosing bookmarks? On Jan 13, 2019 18:29, "James Kittsmiller" notifications@github.com wrote:

Fixed with this commit: netrunner-rolling/netrunner-settings-firefox@69a557e https://github.com/netrunner-rolling/netrunner-settings-firefox/commit/69a557ef2499420a767d0556ba92af0cac8e0309

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/blue-systems/netrunner-releases/issues/169#issuecomment-453849053, or mute the thread https://github.com/notifications/unsubscribe-auth/AAzRhsdC4lPFHU_Prc_aUnKiQEssDy4kks5vC20QgaJpZM4Z84b3 .

NuLogicSystems commented 5 years ago

Changing from using the policies.json to using a distribution.ini for setting default bookmarks shouldn't delete anyone's existing bookmarks.

Note: I did have to rework this for Rolling to use alpm hooks instead since we can't ship the distribution.ini file directly without getting an "exists in file system error".

star-buck commented 5 years ago

So besides Bookmarks, what else would be affected right now? Anything other affect that would happen without a rework on current RC that I could test? On Jan 13, 2019 22:27, "James Kittsmiller" notifications@github.com wrote:

Changing from using the policy.json to using a distribution.ini for setting default bookmarks shouldn't delete anyone's existing bookmarks.

Note: I did have to rework this for Rolling to use alpm hooks since we can't ship a distribution.ini file directly without getting the "exists in file system error".

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/blue-systems/netrunner-releases/issues/169#issuecomment-453867105, or mute the thread https://github.com/notifications/unsubscribe-auth/AAzRhu2qHORiFNPonzHf8KOz6XJboCOhks5vC6TGgaJpZM4Z84b3 .

NuLogicSystems commented 5 years ago

Nothing that I can think of. I've already tested changing the homepage, disabling the menu bar and the bookmarks toolbar. These settings were not permanent, they did not get set back on new launch.

Here are the policies available and what they do: https://github.com/mozilla/policy-templates/blob/master/README.md

Anything of these that says default the user can change, enable, or disable and it will stay that way.

NuLogicSystems commented 5 years ago

After looking through here: https://github.com/mozilla/policy-templates/releases

The policy for bookmarks got an update at the v1.2 release (Policy templates for Firefox 62 and 60.2)

UPDATED: Bookmarks are fixed. Sorry about that.

This must have been requested.