search

blue-systems / netrunner-issues-old

Todos for Netrunner Desktop Releases
0 stars 0 forks source link

FF: cck2 causes error when updating to 58 #26

Open star-buck opened 6 years ago

star-buck commented 6 years ago

https://github.com/netrunner-rolling/QA-Bugs/issues/18#issuecomment-362368073

star-buck commented 6 years ago

Any idea how to fix this without requiring anything special from the user side?

NuLogicSystems commented 6 years ago

Opps, it looks like we both posted this here, I'll close mine.

shadeslayer commented 6 years ago

Hi It seems like this is directly related to https://github.com/mkaply/cck2wizard/issues/75

Could you grab this https://raw.githubusercontent.com/mkaply/cck2wizard/master/cck2/modules/Preferences.jsm and place it in /usr/lib/firefox/cck2/modules/Preferences.jsm to see if it fixes your problem?

NuLogicSystems commented 6 years ago

Nope, that did not help. I'm still getting the exact same error.

shadeslayer commented 6 years ago

Ah damn, is it the same error? Could you perhaps follow up on the cc2kwizard ticket if it is?

NuLogicSystems commented 6 years ago

That thread says something about running a script to clean out or delete the startupCache. There is also another version of this file ziped up and linked to in a later post from the file you linked to.

shadeslayer commented 6 years ago

I presumed you were starting from a empty ~/.mozilla

NuLogicSystems commented 6 years ago

No, even the netrunner-common firefox settings package doesn't have an empty ~/.mozilla folder, but that's not the issue.

After I maually delete my ~/.cache/mozilla folder your file worked. However, it would be better if the end user doesn't need to do this.

shadeslayer commented 6 years ago

Yes, we don't have a empty ~/.mozilla as much as I'd like to :(

NuLogicSystems commented 6 years ago

The .mozilla folder isn't the problem, it the startupcache folder that is (~/.cache/mozilla).

NuLogicSystems commented 6 years ago

Would also changing the "cckVersion": "2.2.3.4" string in cck2.cfg file to "cckVersion": "2.2.3.5" triger a startupcahe update?

NuLogicSystems commented 6 years ago

Update: Changing the cck2 version string seems to have fixed the startupcache issue with the updated Preferences.jsm file on my test machine. @star-buck, could you please update to the new netrunner-settings-firefox package I just pushed to the "netrunner" repo for rolling?

shadeslayer commented 6 years ago

@NuLogicSystems I'd recommend you ship a entirely new CCK2 instead of only changing certain parts.

NuLogicSystems commented 6 years ago

@shadeslayer I don't have FF ESR to run the wizard on, or is it just replacing the modules dir and updateing the version like last time?

shadeslayer commented 6 years ago

It should be as easy as just unpacking the new release over the old one, yes

NuLogicSystems commented 6 years ago

Cool, I need to keep that in mind.

star-buck commented 6 years ago

How to prevent any breakage in the future? On Feb 2, 2018 16:15, "James Kittsmiller" notifications@github.com wrote:

Update: Changing the cck2 version string seems to have fixed the startupcache issue with the updated Preferences.jsm on my test machine.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/blue-systems/netrunner-releases/issues/26#issuecomment-362610085, or mute the thread https://github.com/notifications/unsubscribe-auth/AAzRhhOgtZRJTat-oBjCbYwgNEltCyPOks5tQyN8gaJpZM4R2ISH .

NuLogicSystems commented 6 years ago

There really wasn't many more changes other than the Preferences.jsm file, but I went ahead and updated the other two files as well. https://github.com/netrunner-rolling/netrunner-settings-firefox/commit/6c9e6081067429f9e7c31caf09a11c1a7d285342

NuLogicSystems commented 6 years ago

@star-buck I'd imagine we will need to monitor cck2 for issues and/or updates continually.

shadeslayer commented 6 years ago

@star-buck that entirely depends on Firefox TBH, if they change something in their API to configure settings, then CCK2 of course breaks.

NuLogicSystems commented 6 years ago

Removed my last post. That thread I was concerned about was over 2 years old and not actually effecting me.

star-buck commented 6 years ago

Lets make sure this doesnt hit us again next update... also is this fixed by simply updating our packaging and people continue or help thrmselves via a simple upgrade (not a special upgrade command, just a normal update routine via octopi or discover?) On Feb 2, 2018 19:08, "James Kittsmiller" notifications@github.com wrote:

There really wasn't many more changed than the Preferences.jsm, but I now updated the other two files as well. netrunner-rolling/netrunner-settings-firefox@6c9e608 https://github.com/netrunner-rolling/netrunner-settings-firefox/commit/6c9e6081067429f9e7c31caf09a11c1a7d285342

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/blue-systems/netrunner-releases/issues/26#issuecomment-362644264, or mute the thread https://github.com/notifications/unsubscribe-auth/AAzRhja5sEUYhBXEEVckCXsPpcbm3dzEks5tQ0AvgaJpZM4R2ISH .

NuLogicSystems commented 6 years ago

Since we are updating all of cck2 and not just the Preferences.jsm file, a normal update should be all that is needed.

shadeslayer commented 6 years ago

The best way to make sure we don't hit this again in the future is to write a QA test that ensures that everytime we update Firefox, we ensure that the settings are applied on a clean system.

NuLogicSystems commented 6 years ago

What do you mean by clean system? Manjaro pulls in Arches Firefox package minus the branding. Now that I know we need to update cck2 itself more often, I'll be looking out for that. I'll also need to test FF out more often in the Manjaro testing branch before it hits stable. My build system does run on Manjaro testing, but I don't typically use FF. I only caught it because of the pre-load on one of my test systems.

shadeslayer commented 6 years ago

Should this be closed?