search

blue-systems / netrunner-issues-old

Todos for Netrunner Desktop Releases
0 stars 0 forks source link

Dolphin: updating packages resets dolphin toolbar to default #28

Open star-buck opened 6 years ago

llelectronics commented 6 years ago

Clearly an upstream bug. Dolphin should not do this.

davidedmundson commented 6 years ago

Check the version number in the rc file you're replacing.

If it's older than upstream it'll use upstreams.

NuLogicSystems commented 6 years ago

You mean like I did here: sed -e "s|17|19|" \ -i "$pkgdir/usr/share/default-settings/plasma5-profile/kxmlgui5/dolphin/dolphinui.rc" https://github.com/netrunner-rolling/PKGBUILD-ds9-common/blob/master/default-settings-kdeapps/PKGBUILD This still needs to be packaged and uploaded when I get into the office, but still.

Because of where our file is shipped, it can not be updated by Dolphin itself. If it was under ~.local/share/kxmlgui5/dolphin/ this number would have been changed automatically. As it stands now we need to update this manually each time there is a major revision release.

davidedmundson commented 6 years ago

Can you not just set the version to "9999" in the replacement?

llelectronics commented 6 years ago

Ah ok. Thanks for the tip. Thats what we'll do then.

llelectronics commented 6 years ago

Should be fixed now with this commit: https://github.com/ds9-common/default-settings-kdeapps/commit/72fa5ae2b1f34ee561c905c8473208488c50fa9d

and in future Netrunner versions.

star-buck commented 6 years ago

@NuLogicSystems : same needs to be applied to Rolling?

star-buck commented 6 years ago

now does an updated package retro-fix the situation and restores our default toolbar config in dolphin again?

llelectronics commented 6 years ago

Yes that is what it should do. Basically it just ignored our config as it had an too old version. With the updated config it should read and use the config again.