blue-systems / netrunner-issues-old

Todos for Netrunner Desktop Releases
0 stars 0 forks source link

Package: disable gtk3-csd, install gtk3-mushrooms (gtk3-classic) -or- gtk3-nocsd #56

Open star-buck opened 6 years ago

star-buck commented 6 years ago

PREFERRED: gtk3-classic is the Manjaro package, the arch (AUR) entry and upstream name is gtk3-mushrooms: https://github.com/TomaszGasior/gtk3-mushrooms https://aur.archlinux.org/packages/gtk3-mushrooms/ https://forum.manjaro.org/t/gtk3-classic-gtk3-mushrooms-gtk3-with-my-own-patches/


ALTERNATIVE gtk3-nocsd:

read more: https://www.reddit.com/r/kde/comments/8xfzid/a_small_tip_on_how_to_ditch_csds/

star-buck commented 6 years ago

@NuLogicSystems : how can we best add this to rc5? And share with @llelectronics , @shadeslayer ?

NuLogicSystems commented 6 years ago

IDK the thought of using this never crossed my mind, I'd have to reasearch it. However, I did find these. https://aur.archlinux.org/packages/gtk3-nocsd-git/ https://aur.archlinux.org/packages/lib32-libgtk3-nocsd-git/

NuLogicSystems commented 6 years ago

@star-buck, I also just found this: https://sources.debian.org/src/gtk3-nocsd/3-1/

NuLogicSystems commented 6 years ago

Manjaro on the hand packages gtk3-classic and lib32-gtk3-classic that are built using https://github.com/TomaszGasior/gtk3-mushrooms

Oberon packages these for use on mate, xfce, etc. as an alternative to the default gtk3. Here is the thread: https://forum.manjaro.org/t/gtk3-classic-gtk3-mushrooms-gtk3-with-my-own-patches/

This is what I use on my personal home PC (Enlightenment): http://www.enlightenment.org/ss/e-5b48e301976c87.93288778.jpg

IMHO, I like it's defaults much better, it doesn't require using any scripts, setting any environment variables, or adding any gtk.css changes, just to achieve the desired effect.

NuLogicSystems commented 6 years ago

OK, I'll need to take another look at the AUR packaging again. I've never used this gtk3-nocsd hack before, so I don't know how it looks or act's. I've only used the gtk3-mushroom patches for GTK3 (gtk3-classic).

NuLogicSystems commented 6 years ago

OK, I'm almost done packaging what is needed. No offence, but I do have to say though, that was a lot of jumping through hoops just to do the same thing and actually less than gtk3-classic does.

NuLogicSystems commented 6 years ago

Building ISO now. For debian testing and unstable branches, the existing packages are slightly different than for arch, but they should still work the same way. https://packages.debian.org/testing/gtk3-nocsd

Note: The apply gtk3-nocsd as listed above is not seccesary when using the existing packages.

star-buck commented 6 years ago

What does classic do? Any screenshots of e.g. gnome-chess with only classic installed? How is it made to be applied once installed? On Jul 17, 2018 20:16, "James Kittsmiller" notifications@github.com wrote:

OK.I'm almost done packaging what is needed. No offence, but I do have to say that was a lot of jumping through hoops just to do the same thing and less than gtk3-classic does.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/blue-systems/netrunner-releases/issues/56#issuecomment-405677437, or mute the thread https://github.com/notifications/unsubscribe-auth/AAzRhq-Lc0zogMEGStqWgx7YCEqj3_blks5uHinugaJpZM4VMwPf .

NuLogicSystems commented 6 years ago

I already included a link to a screenshot from my Enlightenment PC above. But I'll embed it this time: This one has a few gtk3 apps running, but I'll do another one with gnome-chess as well. gtk3-classic

The gtk3-classic package was created by the original developer of gtk3-mushrooms with the help of oberon. Here is a link to the readme from github on what his patches do: https://github.com/TomaszGasior/gtk3-mushrooms/blob/master/README.md

There is nothing to do once gtk3-classic is installed, this is a patched version of GTK3. You just replace gtk3 with gtk3-classic and your done. However, there are some enviroment variables that can be set if you wish to undo (bypass the changes) and revert to the normal gtk3 defaults.

NuLogicSystems commented 6 years ago

Here is another screen shot from my Enlightenment computer where I use gtk3-classic: shot-2018-07-17_15-58-10

star-buck commented 6 years ago

Can you post a screenshot how gome chess looks like just by installing gtk3-classic on netrunner rolling? What else needs to be set (like profile settings?) to have classic activated and kwin render the window-decorations around gtk3 apps? On Jul 17, 2018 21:49, "James Kittsmiller" notifications@github.com wrote:

I already included a link to a screenshot from my Enlightenment PC above. But I'll embed it this time: [image: gtk3-classic] https://user-images.githubusercontent.com/10186587/42841549-6c964bd8-89d8-11e8-979f-30e1a4cddc59.jpg

The gtk3-classic package was created by the original developer of gtk3-mushrooms with the help of oberon. Here is a link to the readme from github on what his patches do: https://github.com/TomaszGasior/gtk3-mushrooms/blob/master/README.md

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/blue-systems/netrunner-releases/issues/56#issuecomment-405705230, or mute the thread https://github.com/notifications/unsubscribe-auth/AAzRhl6cwWLjYN_kJe5n9qPQoKv6NgIAks5uHj_NgaJpZM4VMwPf .

NuLogicSystems commented 6 years ago

Nothing needs to be set, unless you need to bypass any changes the patches make. I'll need to remove the packages and settings I just made for gtk3-nocsd on my NRR box first. Give me a few minutes to do that.

NuLogicSystems commented 6 years ago

Here you go: screenshot_20180717_161648

I removed all of the gtk3-nocsd and kwinscript packages and settings, and then installed only the gtk3-classic package in place of gtk3, nothing else needs to be done.

star-buck commented 6 years ago

That looks exactly like expected. Lets go with that then and see if it can be applied on Debian as well.

NuLogicSystems commented 6 years ago

Sounds good. The rc5 ISO is building now, will push it to the server once it's finished.

star-buck commented 5 years ago

@shadeslayer @llelectronics : is gtk3-classic available for debian as well? if not, can we package it?

llelectronics commented 5 years ago

It is not available in debian.

NuLogicSystems commented 5 years ago

gtk3-classic is the Manjaro package, the arch (AUR) entry and upstream name is gtk3-mushrooms: https://github.com/TomaszGasior/gtk3-mushrooms https://aur.archlinux.org/packages/gtk3-mushrooms/ https://forum.manjaro.org/t/gtk3-classic-gtk3-mushrooms-gtk3-with-my-own-patches/

It was discussed for debian at one point, but never went anywhere: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890434

shadeslayer commented 5 years ago

I highly doubt Debian would package those since the maintainer himself claims that the quality of the patches isn't great.

We can look into packaging it up for Netrunner though.

NuLogicSystems commented 5 years ago

That's only because of his limited knowledge of C programming. However, when he brought these to the attention of Manjaro (forum link above), they were examined, discussed, and ultimately packaged for the Manjaro repositories.

Note: We've been shipping with these by default in the rolling edition with no issues. It would be nice if this could be packaged as star-buck suggested/requested for Debian as well.

star-buck commented 5 years ago

@shadeslayer @llelectronics : lets package gtk3-mushrooms (aka gtk3-classics) for debian in our own netrunner repo. I'll test it once available by manually installing first, then decide if we ship it default or not.

TomaszGasior commented 5 years ago

Hello. I am gtk3-mushrooms author. It's nice to hear that you are interested in using my patchset. I am not using netrunner nor I am not going to but I can help you by answering eventual questions about gtk3-mushrooms here. I am using gtk3-mushrooms daily since first release on my all computers.

(BTW gtk3-mushrooms is official name of my AUR package. gtk3-classic name was chosen by Manjaro maintainers for binary package.)

star-buck commented 5 years ago

@TomaszGasior : Thanks a lot! If we have any questions or need help we appreciate to get back to you.