search

blue-systems / netrunner-issues-old

Todos for Netrunner Desktop Releases
0 stars 0 forks source link

appimagelauncher: package latest version and make it installable (currently fails) #68

Open star-buck opened 5 years ago

star-buck commented 5 years ago

libsquashfuse: https://cloud.assassinate-you.net/s/43by7DMDpZnnNKm libappimage: https://cloud.assassinate-you.net/s/fcp3SyHqw8Kjr9E appimagelauncher: https://cloud.assassinate-you.net/s/wYAibxzBWq3x37A

https://github.com/TheAssassin/AppImageLauncher (poke on IRC if needed)

screenshot_20181201_125250

llelectronics commented 5 years ago

Just as info. It is not installable as its dependencies are outdated. Rebuilding is currently only possible manually not in CI and fails because of libcurl4-openssl-dev in testing being apparently too new. Already reported to TheAssassin.

star-buck commented 5 years ago

Okay, please find a solution

TheAssassin commented 5 years ago

Building works just fine again. Working with Scarlett on packaging it "properly" (as in, packaging the dependencies for Debian, main blocker is libappimage). Once that's finished, you can build and ship those packages in a custom repo.

The update functionality would require packaging of libappimageupdate, which we haven't looked into so far, but I'll make it optional so you can build and ship a first version of AppImageLauncher asap.

star-buck commented 5 years ago

So can we or can we not ship a working deb package on monday with libappimage?

Also didnt the update function work with only AIL before, since when do we now need libappimageupdate for that? On Jan 4, 2019 16:35, "TheAssassin" notifications@github.com wrote:

Building works just fine again. Working with Scarlett on packaging it "properly" (as in, packaging the dependencies for Debian, main blocker is libappimage). Once that's finished, you can build and ship those packages in a custom repo.

The update functionality would require packaging of libappimageupdate, which we haven't looked into so far, but I'll make it optional so you can build and ship a first version of AppImageLauncher asap.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/blue-systems/netrunner-releases/issues/68#issuecomment-451477675, or mute the thread https://github.com/notifications/unsubscribe-auth/AAzRhlgSFPSu8WcNIprTRrhK9Sh8e82fks5u_3TEgaJpZM4Y9AgC .

TheAssassin commented 5 years ago

@star-buck I don't know what was shipped before, to be honest. libappimageupdate has always been needed for updating.

I was referring to the "proper" way of packaging things (i.e., Debian style). A quick-and-dirty package can always be built & shipped. (Hint: AppImageLauncher's CMake configuration is doing some bad hacks to build & ship libappimage{,update} privately, same goes for AppImageLauncherFS, ...)

Who's been responsible for packaging AIL? Can this person please pass by on IRC?

star-buck commented 5 years ago

I thought you were responsible to build working packages via travis on github for debian (testing)?

TheAssassin commented 5 years ago

Oh, yes, there's working packages on the GitHub release page. They contain all the dependencies. Did you ship these?

star-buck commented 5 years ago

Working deb packages that install and run fine under netrunner 1901 / debian testing?

star-buck commented 5 years ago

Please link to the package that works here, but is not an appimage.

TheAssassin commented 5 years ago

I just have this snapshot tagged 2018-12-30, and there the "bionic" (I know, the name doesn't quite apply... but they work) packages can be installed (just tested):

https://github.com/TheAssassin/AppImageLauncher/releases/download/continuous/appimagelauncher_1-alpha-travis448.git20190104.f10b11a.bionic_amd64.deb https://github.com/TheAssassin/AppImageLauncher/releases/download/continuous/appimagelauncher_1-alpha-travis448.git20190104.f10b11a.bionic_i386.deb

Caution: links might break soon as I'm working on AppImageLauncher, in this case please visit https://github.com/TheAssassin/AppImageLauncher/releases/tag/continuous and download the "bionic" packages

star-buck commented 5 years ago

Why does odio land in Lost&Found when "installing" with AIL?

https://www.appimagehub.com/p/1282377

TheAssassin commented 5 years ago

Broken desktop file:


> ./odio*.AppImage --appimage-extract
[...]
> desktop-file-validate  squashfs-root/odio.desktop 
squashfs-root/odio.desktop: error: (will be fatal in the future): value item "Audio" in key "Categories" in group "Desktop Entry" requires another category to be present among the following categories: AudioVideo
star-buck commented 5 years ago

Ah okay, can you post a comment to the creator on that product page? On Jan 4, 2019 19:35, "TheAssassin" notifications@github.com wrote:

Broken desktop file:

./odio*.AppImage --appimage-extract [...]> desktop-file-validate squashfs-root/odio.desktop squashfs-root/odio.desktop: error: (will be fatal in the future): value item "Audio" in key "Categories" in group "Desktop Entry" requires another category to be present among the following categories: AudioVideo

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/blue-systems/netrunner-releases/issues/68#issuecomment-451529242, or mute the thread https://github.com/notifications/unsubscribe-auth/AAzRhoMmOxM4ITsLzX5d_dG9bbzV_hiwks5u_57sgaJpZM4Y9AgC .

TheAssassin commented 5 years ago

That app isn't free software, it seems (I can't find the source download), but there's an issue tracker on GitHub. Will post it there.

ScarlettGatelyMoore commented 5 years ago

According to the original bug https://github.com/blue-systems/netrunner-releases/issues/31 A cpack was generated with the last release by @shadeslayer This is another case where debian is a blocker in timely uploads. appimagelauncher depends on libappimage which depends on squashfuse ( been packaged since October but stuck in debian review process ) To be fair they are a community of volunteers! In short - debian packaging is available for squashfuse: https://salsa.debian.org/sgclark-guest/squashfuse libappimage: https://salsa.debian.org/sgclark-guest/libappimage appimagelauncher: https://salsa.debian.org/sgclark-guest/appimagelauncher

With that said - the cpack method might be our best move here given the time constraints. We can add custom repos for the next release. I just fear adding untested debian packages to a major release might not be the best idea. I will do whatever is required though.

star-buck commented 5 years ago

Can we produce (or do we already have produced) all 3 packages as debs that work with current RC3 snapshot, so they can be manually installed and tested and then eventually be shipped default?

Links please.

TheAssassin commented 5 years ago

Is this the "current RC3"? http://ds9-eu.s3-eu-central-1.amazonaws.com/dci/images/next/amd64/netrunner-desktop/netrunner-20181230.1710-amd64.hybrid.iso

llelectronics commented 5 years ago

Yes

ScarlettGatelyMoore commented 5 years ago

With some great teamwork with @TheAssassin, I have debs for all 3, however I am going to test them first, in the rc3 linked above, so as to not waste anyone's time. Once I am happy, I will upload them to umm transfer.sh I guess, I do not have any cloud space.

star-buck commented 5 years ago

Sounds great, let us know if they do work.

ScarlettGatelyMoore commented 5 years ago

Ok so tested on RC3 and my debian teesting box it works. There is one popup error box Failed to register AppImage in AppImageLauncherFS: could not open map file Which @TheAssassin is aware of. It does not seem to impact the functionality though.

These must be installed in order: libsquashfuse: https://cloud.assassinate-you.net/s/43by7DMDpZnnNKm squashfuse: https://cloud.assassinate-you.net/s/43by7DMDpZnnNKm libappimage: https://cloud.assassinate-you.net/s/fcp3SyHqw8Kjr9E appimagelauncher: https://cloud.assassinate-you.net/s/DjrYxifsX2gH5Xe

TheAssassin commented 5 years ago

squashfuse shouldn't be needed.

star-buck commented 5 years ago

If that error comes up every time an appimage is doubleclicked, I cant ship it, as it looks erronous to anyone even if it works. On Jan 6, 2019 18:26, "Scarlett Gately Moore ( Clark )" < notifications@github.com> wrote:

Ok so tested on RC3 and my debian teesting box it works. There is one popup error box Failed to register AppImage in AppImageLauncherFS: could not open map file Which @TheAssassin https://github.com/TheAssassin is aware of. It does not seem to impact the functionality though.

These must be installed in order: libsquashfuse: https://cloud.assassinate-you.net/s/43by7DMDpZnnNKm squashfuse: https://cloud.assassinate-you.net/s/43by7DMDpZnnNKm libappimage: https://cloud.assassinate-you.net/s/fcp3SyHqw8Kjr9E appimagelauncher: https://cloud.assassinate-you.net/s/DjrYxifsX2gH5Xe

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/blue-systems/netrunner-releases/issues/68#issuecomment-451758862, or mute the thread https://github.com/notifications/unsubscribe-auth/AAzRhjS-wBM2UuSliBSWj3asNSEaU1Hlks5vAjG8gaJpZM4Y9AgC .

TheAssassin commented 5 years ago

@star-buck it's just the first-ever run that is affected. I need to be able to reproduce the issue first before testing a fix, though. I'm quite confident it will be fixed tonight.

star-buck commented 5 years ago

First ever run of every appimage to be installed is what i meant? Or only one time ever and since its preinstalled the user will never see it again when installing appimages? On Jan 6, 2019 19:41, "TheAssassin" notifications@github.com wrote:

@star-buck https://github.com/star-buck it's just the first-ever run that is affected. I need to be able to reproduce the issue first before testing a fix, though. I'm quite confident it will be fixed tonight.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/blue-systems/netrunner-releases/issues/68#issuecomment-451764166, or mute the thread https://github.com/notifications/unsubscribe-auth/AAzRhjRVSTnJYEelFnduVd4WS2m8qR9Iks5vAkNwgaJpZM4Y9AgC .

TheAssassin commented 5 years ago

The issue was that the AppImageLauncher file system needed a bit longer than expected to start up before said map file could be read. This is an issue once only, as AppImageLauncher starts the service and enables auto-restarting and also autostart on reboot for the specific user.

I've rewritten this section in the code, and it should be more robust now. Please give me a few minutes to test this on the latest Netrunner RC.

TheAssassin commented 5 years ago

Seems to work. Will test on a few more distros. If it works, I think we can release a 1.0.0 and call it a day.

ScarlettGatelyMoore commented 5 years ago

Here is the deb for 1.0.0 release :) https://cloud.assassinate-you.net/s/wYAibxzBWq3x37A

I have tested it in RC3 and all looks good!

star-buck commented 5 years ago

I installed all 3 packages, clicked on the odio appimage and got this instead of the AIL dialog: screenshot_20190108_225040

I clicked NO, then closed the program again.

Right-click on the appimage gave me this dialog: screenshot_20190108_225259

I installed and app was moved to "Applications" folder.

Now starting the app from Lost and Found in menu still gave me this again: screenshot_20190108_225403

This is correct so far or am I missing something? Expected behaviour if AIL catched the hook would be preventing this dialog and only showing the AIL one once and then only again if chosen via right-click?

TheAssassin commented 5 years ago

MIME type integration seems to work, binfmt_misc however seems broken. Can you please ls /proc/sys/fs/binfmt_misc/ and check for two files appimage-type{1,2}?

Is this a fresh install, a live VM (as @ScarlettGatelyClark and I used) or an upgraded existing system?

ScarlettGatelyMoore commented 5 years ago

I don't know if I can close these - but this issue ( package latest version and make it install-able is now fixed https://dci.netrunner.com/view/Netrunner%20Desktop/view/Netrunner%20Desktop%20Next/view/All/job/next_desktop_dci-extras-packaging_appimagelauncher_src/ I tested it in latest next image and everything seems to work. https://dci.netrunner.com/view/Images/view/Netrunner%20Next%20Images/view/Netrunner%20Desktop%20AMD64/view/All/job/img_desktop_netrunner-desktop_next_amd64/36/s3/download/netrunner-20190623.1308-amd64.hybrid.iso

TheAssassin commented 5 years ago

Seem to work, @ScarlettGatelyMoore. Great!

probonopd commented 5 years ago

netrunner-20190623.1308-amd64.hybrid.iso download running. It would be super awesome if there was also a zsync file at https://dci.netrunner.com/view/Images/view/Netrunner%20Next%20Images/view/Netrunner%20Desktop%20AMD64/view/All/job/img_desktop_netrunner-desktop_next_amd64/ so that one could go from build to build without redownloading the whole thing...

ScarlettGatelyMoore commented 5 years ago

I have no idea how to accomplish that, but I will try to sort it out. Here is that latest build https://dci.netrunner.com/view/Images/view/Netrunner%20Next%20Images/view/Netrunner%20Desktop%20AMD64/view/All/job/img_desktop_netrunner-desktop_next_amd64/37/s3/download/netrunner-20190623.2110-amd64.hybrid.iso - however that iso will work but you will need an apt update to get the new release.

probonopd commented 5 years ago

I have no idea how to accomplish that, but I will try to sort it out.

Thank you. Just run zsyncmake on the iso. It should generate a .iso.zsync file that needs to be put in the same web server directory as the .iso file.

More information: https://help.ubuntu.com/community/ZsyncCdImage