search

blue-systems / netrunner-issues-old

Todos for Netrunner Desktop Releases
0 stars 0 forks source link

gtk2-settings-kcm: breeze dark not fully applied #84

Closed star-buck closed 5 years ago

star-buck commented 5 years ago

the preview shows this: screenshot_20181209_122135 but apps menus are still like this even after reboot: screenshot_20181209_122615 screenshot_20181209_122712 screenshot_20181209_122746

could be we have netrunner gtk configs somewhere preventing a clean change from breeze to something else?

llelectronics commented 5 years ago

Yeah had the same issue on Neptune aswell. The issue comes from the way we ship the gtk settings. We ship them in /etc/gtk-{2,3}-0 as a global setting. Apparently whatever we set in there as gtk-theme has priority over whatever is set for the user in ~/.config @shadeslayer I would suggest switching back to shipping those gtk config in /etc/skel/ again to "fix it" for now. It smells like a bug to me that /etc/gtk~ stuff is overprioritized though I am not sure where to even look at and if it isn't maybe a wanted behavior.

star-buck commented 5 years ago

@kbroulik : do you know if this is intended or a bug? in any case, we need this to be working wether we default ship a dark theme (which i am testing for "blackbird") or light theme and the people want to switch themselves

shadeslayer commented 5 years ago

Shipping a file in skel would break themeing customisations for GTK apps that require root, like synaptic.

On a more serious note, what the fuck GTK?

On Sun, 9 Dec 2018, 12:44 Leszek Lesner <notifications@github.com wrote:

Yeah had the same issue on Neptune aswell. The issue comes from the way we ship the gtk settings. We ship them in /etc/gtk-{2,3}-0 as a global setting. Apparently whatever we set in there as gtk-theme has priority over whatever is set for the user in ~/.config @shadeslayer https://github.com/shadeslayer I would suggest switching back to shipping those gtk config in /etc/skel/ again to "fix it" for now. It smells like a bug to me that /etc/gtk~ stuff is overprioritized though I am not sure where to even look at and if it isn't maybe a wanted behavior.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/blue-systems/netrunner-releases/issues/84#issuecomment-445530418, or mute the thread https://github.com/notifications/unsubscribe-auth/AALiMMvmidS5EpWGT49rVQCKH7YD8vhVks5u3PeAgaJpZM4ZKE28 .

star-buck commented 5 years ago

well, gnome devs dont seem to care much about themeing in general these days... we still need to fix this, but synaptic root did also not change selecting a dark theme with current iso?

star-buck commented 5 years ago

removing the etc/gtk* folders does fix the issues, and i think the synaptic not changing themes is the lesser error at this point (it does look better without breeze even imo and seems to have fixed the multiple entires issue, or was that fixed by something else)?

kbroulik commented 5 years ago

do you know if this is intended or a bug?

I would have assumed user settings to override system settings as in KDE but apparently Gnome is special again :) Shouldn't kde-gtk-config which writes into gtk2 and 3 settings be enough with no /etc/skel changes required? Or even just "krdb" (plasma-desktop) which syncs Plasma colors to Gtk colors?

llelectronics commented 5 years ago

For now moved the gtk theme settings to skel again: https://github.com/netrunner-common/netrunner-settings-theming/commit/a78f3d340622b6550b7c5b6f883205585cd698ec