blue-systems / netrunner-issues-old

Todos for Netrunner Desktop Releases
0 stars 0 forks source link

Lookandfeel: Rename "Netrunner Black X" to "Netrunner Default", rename Netrunner Blue X to "Netrunner Blue" #85

Closed star-buck closed 5 years ago

star-buck commented 5 years ago

this in preparation of a new "Netrunner Black" theme (without the X)

llelectronics commented 5 years ago

We have a Netrunner Desktop LNF already which is always the default loaded by plasma. Should we really rename Netrunner Black X to Netrunner ? Maybe we can leave the name and change it accordingly to the Blue simple Netrunner Black. The new theme we can call and add as Netrunner Dark? Also for the sake of upgrading easily the package names for the blue x and black x package won't change anyway.

star-buck commented 5 years ago

Black is not really Black, and the new theme should be called Black to due Blackbird. So yes, lets rename the Netrunner BlackX to "Netrunner" or "Netrunner Default", or if the current LNF is actually restoring the theme to be like this, we can remove blackx and name that theme "Netrunner Default"?

llelectronics commented 5 years ago

So the current BlackX stays the default look and feel in netrunner? Then of course we could rename it to "Netrunner default" in the menu. Though the paths and package name needs to stay blackx otherwise the risk is very high it might break something for people who upgrade

llelectronics commented 5 years ago

Reanmed it now here: https://github.com/ds9-artwork/lnf-theme-blackx/commit/8e109596b5efd4f57a438bdca3fb0f957b08ed6e

star-buck commented 5 years ago

now what exactly is the difference between Netrunner Desktop and Netrunner Default? screenshot_20181214_224651

star-buck commented 5 years ago

if both are the same, we could remove "Netrunner Default" and only leave Netrunner Desktop?

llelectronics commented 5 years ago

Almost the same. The Desktop one also contains the setup scripts for setting up the panel and desktop containment.

star-buck commented 5 years ago

if we can safely get rid of Netrunner Default, then lets do that.