search

blue-systems / plasma-5.5

Plasma 5.2 - 5.5
0 stars 0 forks source link

[Notifications]: no start sound played #119

Closed star-buck closed 9 years ago

star-buck commented 9 years ago

even though a start sound for logging event has been set in kcm, no sound is played. (I think we had this ticket opened in the past, but couldnt find it, so added this one)

mck182 commented 9 years ago

There is an upstream bugreport here - https://bugs.kde.org/show_bug.cgi?id=335948

It was fixed, then reverted as on some systems it was starting PulseAudio during the login sequence and that has blocked the startup considerably.

It could be tried to invoke alsa directly for the playback (like using aplay) or maybe even just another thread/process which wouldn't block ksmserver in startup.

I was never able to reproduce the PulseAudio blocking though so I have no way for testing that. Can anybody please try uncommenting plasma-workspace/ksmserver/startup.cpp:402 and see if login blocks for you?

mgraesslin commented 9 years ago

could we start the notification from a thread? That way it would not matter if it blocks or not.

mck182 commented 9 years ago

Probably, but I can't say if that fixes it because I don't have that blocking problem in the first place. So it'd be handy if someone could reproduce first.

I'll try to patch it blindly nevertheless.

mck182 commented 9 years ago

http://commits.kde.org/plasma-workspace/b0fe26bfb314698693fcf011e59a28769bd9a437

star-buck commented 9 years ago

@apachelogger : please package here: https://launchpad.net/~netrunner-os/+archive/ubuntu/netrunner-16-ci-updates

hsitter commented 9 years ago

https://launchpad.net/~netrunner-os/+archive/ubuntu/netrunner-16-ci-updates/+sourcepub/5068670/+listing-archive-extra

star-buck commented 9 years ago

works!! awesomeness :)

star-buck commented 9 years ago

too fast, seems to work only half-way: After having updated and now trying to logout, kdeinit5 crashes with some "Phonon-Audiooutput" message, that might be related? @mck182: any idea if this could cause logout problems, maybe it checks if to play a logout sound (which none is set, but still)?

hsitter commented 9 years ago

https://launchpad.net/~netrunner-os/+archive/ubuntu/netrunner-16-ci-updates/+sourcepub/5069883/+listing-archive-extra

mck182 commented 9 years ago

For the record, this patch is now upstream (and extended a bit) at http://quickgit.kde.org/?p=plasma-workspace.git&a=commit&h=c445f99304bd0190a7a0b83e4700222132bc34d1

Plus there's an optimization that will not initialize the audio system at all if the sound is not enabled: http://quickgit.kde.org/?p=plasma-workspace.git&a=commit&h=2e60c27a85bd8c785db47be176f6b78a2d3c4ba8

I'd suggest to pick those two commits and have them replace the original patch on plasma-workspace.

NuLogicSystems commented 8 years ago

This has been fixed in Plasma 5.4.