search

blue-systems / plasma-5.5

Plasma 5.2 - 5.5
0 stars 0 forks source link

systemsettings: colorscheme: "apply" does no longer apply colorscheme immediatly to systemsettings window #42

Closed star-buck closed 9 years ago

notmart commented 9 years ago

the color kcm seems to signal on dbus on the service org.kde.KGlobalSettings that the settings are changed: has this gone away?

davidedmundson commented 9 years ago

Someone "ported" the colors KCM away from KDELibs4Support last week; that DBus signal is now emitted by hand.. clearly wrongly.

mgraesslin commented 9 years ago

KGLobalSettings is IIRC deprecated and the signal might just be lost in kdelibs4support

notmart commented 9 years ago

the signal seems to be exactly the same as before the porting an org.kde.kglobalsettings service should still exist, but apparently it doesn't.. how should we do it now then?

davidedmundson commented 9 years ago

That signal part is working fine; it's going into loadPalette and if (mKdeGlobals->hasGroup("Colors:View")) in khintsettings; yet not updating properly.

Not sure if it's the config not syncing fully, or Qt has a problem with QEvent::ApplicationPaletteChange

davidedmundson commented 9 years ago

Fixed. https://git.reviewboard.kde.org/r/121536/ It clearly never worked.. whoever wrote that part totally sucks.

Breeze still seems to have an issue which is Breeze specific. Will fix that next.

star-buck commented 9 years ago

works as of 20150109