search

blue-systems / plasma-5.5

Plasma 5.2 - 5.5
0 stars 0 forks source link

[plasma themes apply]: may look different when just applied vs. logging out and in again #51

Closed star-buck closed 9 years ago

star-buck commented 9 years ago

themes should fully update to look the way they are (broken or not) right when being applied, and no different after logout and in again

eikehein commented 9 years ago

First fix from me: http://commits.kde.org/plasma-desktop/e0d546133656fadc3b536d4b417fe00c13265c04

This fixes the inside panel margin (between panel edge and contents) not updating when switching themes.

In parallel we've analyzed the problem with task buttons (and other things) not receiving visual updates properly when switching themes and Marco has tracked it to a problem in FrameSvgItem's texture generation code; he says he'll address it tomorrow.

We should get this fixed in time for 5.2 overall.

notmart commented 9 years ago

the other part is a problem in the textures management of FrameSvgItem, I'll take a look tomorrow

notmart commented 9 years ago

The biggest rendering problems should be fixed as well now. It may still happen that some applets don't immediately update all the elements, but that's because they were using something that doesn't signal, like Svg::hasElement(), so they will be fixed individually as they are found

eikehein commented 9 years ago

packages: plasma-desktop, plasma-framework fixed: Tue 13th target ISO: Fri 16th qa method: switch between Breeze and Gnome-Shell-KDE at runtime

eikehein commented 9 years ago

Note that the kglobalaccel ticket suggests that the Fri 16th ISO might still have KF5 from the 9th so half the fix might be missing if plasma-framework on the ISO is also from the 9th.

(Repeating my wish for the ISO announcement mail to contain a package manifest with git hashes and dates!)

star-buck commented 9 years ago

looks good in kci 20150116

star-buck commented 9 years ago

still could be improved: When a theme gets applied, some Plasma elements may look broken due to the theme being "wrongly designed"...then a properly designed theme should at least look the same when applied, so its not needed to logout and login again to "fix" the look of a formerly broken theme.

Example: Install "Midna" Theme from GHNS (which ironically is dubbed "Plasma5" ready) and apply. The theme looks somewhat broken already, and after logout and relogin it breaks severly (at least here on kci). Now applying a "well-designed/working" Plasma5 theme like Oxygen should fix the look without the need to logout and login again, but the look of for example the panel stays broken until logged out and in again. Hence the apply=update mechanism doesnt work completely. It would be great if we could make that work 100% for all properly designed themes and maybe even restore somewhat the look of a Plasma4 theme to not completely break.

notmart commented 9 years ago

a problem seems that checking if a particular theme element is present or not can't be done with the qproperties system, so isn't as "magic" as in qml usually is. This will have to be fixed by hand in every place the problem occurs, to recheck the correct element id when the theme changes. So far i've identified one problem in the panel and one in the taskbar, will fix today.

notmart commented 9 years ago

With last commits of today in plasma-framework and plasma-desktop, the panel and task manager should render correctly right after the theme is changed. Are there other parts that look broken right after the theme changes?

eikehein commented 9 years ago

The TM fix is wrong imho, let's talk on IRC

notmart commented 9 years ago

a revised version has been pushed

eikehein commented 9 years ago

^ Thanks, TM fix merged into EITM now as well

star-buck commented 9 years ago

seems to work better now, closing this then.