search

blue-systems / plasma-5.5

Plasma 5.2 - 5.5
0 stars 0 forks source link

[black icons]: some icons in menu seem missing, appear as black squares #95

Closed star-buck closed 9 years ago

star-buck commented 9 years ago

black-icons

eikehein commented 9 years ago

mck182, iirc you had the upstream QTBUG number for that ...?

mck182 commented 9 years ago

No, unfortunately; I reported it to you on irc and someone else said something else, possibly with a QTBUG, I really don't remember :)

eikehein commented 9 years ago

Could also be a bug in QIconItem when it gets an empty QIcon ...

eikehein commented 9 years ago

Looks like it's a regression caused by a commit from ogoffart to kiconthemes: https://bugs.kde.org/show_bug.cgi?id=345740

eikehein commented 9 years ago

It turns out that the fallback icons apparently only worked accidentally in the library prior to ogoffart's commit, and the commit addresses that. So this adds explicit fallbacks to Kicker now:

https://commits.kde.org/plasma-desktop/aa08cd42a470af7a10f34cc9dbe7aefd0057bb35

Independent of that QIconItem should be fixed not to show a black square on an empty texture, however.

star-buck commented 9 years ago

seems fixed?