search

blue-systems / plasma-issues

plasma 5.6 - 5.xx (ongoing)
0 stars 0 forks source link

window deco: options: double-click on menu to close: change behaviour for showing menu to MS Windows like (that is to one short click reveals menu, double click closes it) #161

Open star-buck opened 5 years ago

star-buck commented 5 years ago

it worked great in kde4, so why this annyoing long hold since new users dont even read that text if it ships default in netrunner? snap 2019-01-30 at 23 57 41

zzag commented 5 years ago

This default value comes from /usr/share/netrunner-core-settings/plasma5-profile/kwinrc (in KWin CloseOnDoubleClickOnMenu is off by default). Do I have access to any related repos so I could change it?

davidedmundson commented 5 years ago

@zzag starbuck wants the double click to close, but still have the menu on normal single click.

" so why this annyoing long hold"

Whilst it worked in KDE4 for you, looking at the history it was something that didn't for everyone [1]: as the two click types interfere with each other. It probably depended on double click settings.

It was changed to have the long hold in 4.9.

Kai has written a patch last time it came up that I think solves the problem of the bug report in a way that doesn't involve requiring the user performing the long press behaviour [2].

It was effectively rejected at the time.

That patch is something that can be shipped in Netrunner right now.

As I happen to agree with Kai's patch I'll try and tactfully restart that discussion in the 5.16 cycle and we can see where that takes us

[1] https://bugs.kde.org/show_bug.cgi?id=157184 [2] https://phabricator.kde.org/D10855

star-buck commented 5 years ago

For the record, it doesnt interfere normally with closing on doubleclick as 20+ years of windows doing it shows. It opens as fast as possible if singleclicked and simply closes both window and menu on doubleclick. Anyone with a windows os can easily verify.

davidedmundson commented 5 years ago

I can fully believe it doesn't interfere on windows.

On X when the popup menu appears it grabs the mouse and all future mouse events. If that happens KWin doesn't get notified of the second click.

star-buck commented 5 years ago

What does the patch from Kai Uwe do?

Thanks @davidedmundson @zzag for looking into this anyway.

davidedmundson commented 5 years ago

It delays opening the popup by the double click amount after you release the mouse. It's hardly noticeable but gives kwin just enough time to determine what the intended action was.

FWIW, on wayland we don't need any hacks. I tested removing them and everything worked just fine. #wayalandwillfixit