Patch method doesn't include a payload

blue-veery-gmbh / spring-rest-2-ts

spring rest 2 ts is typescript generator which produces data model and services in typescript based on Spring MVC annotations. It supports generation for Angular and React

MIT License

64 stars 17 forks source link

Patch method doesn't include a payload #32

Closed TiagoJacobs closed 2 years ago

TiagoJacobs commented 2 years ago

Hello, the patch generated method is currently not including a payload.

I think this method could be renamed: https://github.com/blue-veery-gmbh/spring-rest-2-ts/blob/master/spring-rest2ts-spring/src/main/java/com/blueveery/springrest2ts/implgens/Angular4ImplementationGenerator.java#L234

Are you ok with this solution? If so, I can send a PR.

Thanks

tomasz-wozniak75 commented 2 years ago

Hey Tiago We didn't use PATCH method at that time so we assumed that no one will needed it :) The method name should be something like requestCouldHaveBody or bodyIsAllowed also better name is welcome and You can add test for PATCH in this method. Please make version-1.5.0 branch as target of your PR I will make a small release in a day or two after your PR. Thanks for pointing out this problem Tomasz

tomasz-wozniak75 commented 2 years ago

Hey Tiago Please try version 1.5.0 it should fix your problem