search

blue-yonder / azure-cost-mon

Prometheus exporter for the Azure billing API
MIT License
61 stars 13 forks source link

Add metrics for allocated and reserved VM usage #14

Closed MathMagique closed 6 years ago

MathMagique commented 6 years ago

Hi Manuel!

With this pull request, I introduce new metrics for monitoring the number of reserved and allocated VMs per region and size. This is particularly important if you rely on Microsoft Azure's reserved instance payment model and you want to make sure that you perfectly match your actual demand.

The changes I have made are breaking in that the name of a configuration variable needs to change to reflect that now there is more than one metric. The new metrics are completely optional, however.

@StephanErb @hoffmann: It would be great if you could also have a look and fix the things I have overlooked ;-)

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling a10098dc9b1db8d7cebd7d1e1bdc508a56d54977 on MathMagique:master into 55efe516b26e95fae944bda7030ff7293558cfa7 on blue-yonder:master.

MathMagique commented 6 years ago

Fixed the Python 3 issues that I overlooked 😇

MathMagique commented 6 years ago

@StephanErb I think I have addressed all issues :-)