introduce new billing timeout configuration value

blue-yonder / azure-cost-mon

Prometheus exporter for the Azure billing API

MIT License

61 stars 13 forks source link

introduce new billing timeout configuration value #18

Closed ghost closed 6 years ago

ghost commented 6 years ago

The default timeout for requests is set to 10 seconds. Scraping the billing API might take longer. Introducing a configuration value to make it mor customisable.

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling 14fbdc1d2effa02ae7a971af131ac6cf57ababd3 on feature/introduce-scrape-timeout-configuration into bd6a7a4f9559a5f68c82f416dc5b50e928ff96e5 on master.

MathMagique commented 6 years ago

Why do we need this configuration variable? To my understanding, Prometheus will transfer a header that contains the scraping timeout for this very request.

ghost commented 6 years ago

IMHO yes, because you might want to see the output without the need of scraping from Prometheus point of view.

StephanErb commented 6 years ago

Thanks, code change looks good to me. Please also add a changelog entry. Once this is done, feel free to merge.