[REVIEW] added offset - Githubissues

blue-yonder / bonfire

A CLI Graylog Client with Follow Mode

BSD 3-Clause "New" or "Revised" License

72 stars 26 forks source link

[REVIEW] added offset #23

Closed rosscdh closed 2 years ago

rosscdh commented 7 years ago

We have a large datasource that has a total of more than of 10000 records, need this param passed in

coveralls commented 7 years ago

Coverage remained the same at 84.775% when pulling 598f12c931790613634d53e21184e4050966f579 on rosscdh:feature/added-offset-for-large-querysets into d0af9ca10394f366cfa3c60f0741f1f0918011c2 on blue-yonder:master.

valentin-krasontovitsch commented 5 years ago

I'm sorry, but could you please elaborate in a bit more detail why this is a necessary / useful change?

Personally, and I can obviously only speak for my own use-cases, i just limit with -n 10000 if I know I'm potentially getting a lot of data - could you describe a use-case where that is not an option, and offset is more suitable?

valentin-krasontovitsch commented 2 years ago

closing due to inactivity. feel free to comment if this is still relevant (and please remember to elaborate on your use case ^^)