Closed valentin-krasontovitsch closed 3 years ago
Tests actually appear to fail with a newline error. Mind fixing that up?
Of course, I'll take a look at it! Would you mind posting a bit more info so I can reproduce more quickly and know what you're referring to?
On Fri, May 11, 2018 at 5:53 PM, Jose Diaz-Gonzalez < notifications@github.com> wrote:
Tests actually appear to fail with a newline error. Mind fixing that up?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/blue-yonder/bonfire/pull/29#issuecomment-388405398, or mute the thread https://github.com/notifications/unsubscribe-auth/APMdBbGn2qwkTbhT9n1lIs6Z9SYkLquwks5txbQUgaJpZM4T2d-k .
The tests are linked via travis-ci, and here is a failing run: https://travis-ci.org/blue-yonder/bonfire/jobs/376320016
duh, of course they are... thanks : ) gonna fix asap.
On Sat, May 12, 2018 at 11:59 PM, Jose Diaz-Gonzalez < notifications@github.com> wrote:
The tests are linked via travis-ci, and here is a failing run: https://travis-ci.org/blue-yonder/bonfire/jobs/376320016
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/blue-yonder/bonfire/pull/29#issuecomment-388586213, or mute the thread https://github.com/notifications/unsubscribe-auth/APMdBUxnI9TEqL9QlX8hWqbLTTQ3uDnCks5tx1tegaJpZM4T2d-k .
closing in favor of #34
list of fixes:
unfortunately I discovered the tests too late, so while they still pass, I didn't add any new tests to cover the things i fixed... that totally and immediately goes on the todo list though : )