Closed SimeonStoykovQC closed 6 months ago
@SimeonStoykovQC Can you rebase/merge with main?
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
10f7133
) 98.81% compared to head (6e1e5a2
) 98.86%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Please add a changelog entry.
Motivation
4.5.8 (or 4.5.7) introduced a different utf16<->utf8 conversion (using
wstring_convert
instead of boost's conversion library), which considerably slows down the reading of string data - I observed 10x slowdown with 1m rows of characters.Apart from the performance improvement, the changes are warranted because wstring_convert was deprecated in C++17.
Changes
wstring_convert
in favor of simdutfboost
implementation (no formal benchmark in this PR - just local tests),