search

blue-yonder / turbodbc

Turbodbc is a Python module to access relational databases via the Open Database Connectivity (ODBC) interface. The module complies with the Python Database API Specification 2.0.
http://turbodbc.readthedocs.io/en/latest
MIT License
616 stars 86 forks source link

Add pyproject.toml to build artifact to meet pep517 #401

Closed cshaley closed 10 months ago

cshaley commented 10 months ago

pyproject.toml was missing in the tar.gz build artifact. This caused the command pip wheel --use-pep517 "turbodbc==4.8.0" to fail.

I verified the problem with the below commands and then tested the change the same way.

cmake -DBOOST_ROOT=$CONDA_PREFIX -DBUILD_COVERAGE=ON -DCMAKE_INSTALL_PREFIX=./dist -DPYTHON_EXECUTABLE=$(which python) -GNinja .. && ninja && cmake --build . --target install && cd dist && python setup.py sdist

pip wheel --use-pep517 "dist/turbodbc-4.9.0.tar.gz"
codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f7b3f1e) 98.81% compared to head (5776003) 98.81%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #401 +/- ## ======================================= Coverage 98.81% 98.81% ======================================= Files 94 94 Lines 3030 3030 ======================================= Hits 2994 2994 Misses 36 36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rxm7706 commented 10 months ago

@cshaley @xhochy thank you ! I really wonder how many people care about PiP and conda packages releases being available to everyone as soon as possible - especially when a CVE is found and patched by upstream maintainers so quickly.

But I'm glad to see how fast the Pyarrow contributors reacted, and we are close to having both TurboODBC and ML-Flow patched and available for use through PiP, Poetry and Conda. Thank you for your time,