blueCFD / Core

Coordination repository for the blueCFD-Core: Issue tracking, Wiki, project webpage and miscellaneous scripts
http://bluecfd.github.io/Core
53 stars 10 forks source link

Issues with long path names for feature edges #244

Open wyldckat opened 2 years ago

wyldckat commented 2 years ago

snappyHexMesh uses an interesting feature from OpenFOAM: it can lookup feature edge mesh files and triSurface files from both the current processor folder and the root folder of the case.

Now, this is nice and all, but on Windows it leads to the issue where the case folder might use one convention of folder name and the feature edge mesh folder/path uses another, e.g.:

C:/cases/long_case_name
//?/c/cases/long_case_name/processor0/constant/triSurface/geom.stl

This means that the method Foam::fileOperations::masterUncollatedFileOperation::filePath will not work properly on Windows.

The workaround is to use show path names for everything or perhaps enforce both paths to use UNC, but still...

wyldckat commented 3 months ago

Note: OpenFOAM 12 has changed things considerably, so it's not easy to test this out-of-the-box with an old case.

wyldckat commented 3 months ago

TODO Adopting the long path support in general, i.e. UNC variant of the path when the path is too long, e.g. asLongPath in the class fileName.

  1. This is because both creating folders and filenames themselves will need special handling of the paths.
  2. In the meantime, we can provide the -case argument with the UNC form of the current path, if need-be, in order for it to be inherited.

This comment is a follow up to what was done in the following commits: